Skip to content

Commit 22a2235

Browse files
committed
Update on "[Executorch] Renable operator optimization flags"
Previous attempt at this resulted in revert due to app size increase. Much of this was due to op_div exploding. Two diffs underneath solve this issue Differential Revision: [D65606666](https://our.internmc.facebook.com/intern/diff/D65606666/) [ghstack-poisoned]
2 parents 23802a0 + 6889c51 commit 22a2235

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

shim/xplat/executorch/kernels/portable/op_registration_util.bzl

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1279,9 +1279,16 @@ CUSTOM_OPS = (
12791279
),
12801280
)
12811281

1282+
# Lists which ops are refactored into separate impl files that can be reused elsewhere.
1283+
# Not the best way to track this since we should not have list files like this at all
1284+
# but maybe we can figure out how to refactor selective build.
1285+
ATEN_OP_IMPLS = ["op_div"]
1286+
12821287
def portable_source_list():
12831288
"""All the source file names from //executorch/kernels/portable/cpu/"""
1284-
return [op["name"] + ".cpp" for op in ATEN_OPS + CUSTOM_OPS]
1289+
sources = [op["name"] + ".cpp" for op in ATEN_OPS + CUSTOM_OPS]
1290+
sources = sources + [op + "_impl.cpp" for op in ATEN_OP_IMPLS]
1291+
return sources
12851292

12861293
def portable_header_list():
12871294
"""All the header file names from //executorch/kernels/portable/cpu/"""

0 commit comments

Comments
 (0)