Add arm64 size_test

Author: mergennachin

.github/workflows/pull.yml

@@ -371,53 +371,28 @@ jobs:
         # see if we can import the module successfully
         python -c "from executorch.extension.pybindings import portable_lib; print('success!')"
 
-  test-binary-size-linux-gcc:
-    name: test-binary-size-linux-gcc
-    uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
-    permissions:
-      id-token: write
-      contents: read
-    strategy:
-      fail-fast: false
-    with:
-      runner: linux.2xlarge
-      docker-image: executorch-ubuntu-22.04-gcc9
-      submodules: 'true'
-      ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
-      timeout: 90
-      script: |
-        # The generic Linux job chooses to use base env, not the one setup by the image
-        CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
-        conda activate "${CONDA_ENV}"
-
-        ./install_requirements.sh --use-pt-pinned-commit
-        # build module for executorch.extension.pybindings.portable_lib
-        bash test/build_size_test.sh
-        strip cmake-out/test/size_test
-        output=$(ls -la cmake-out/test/size_test)
-        arr=($output)
-        size=${arr[4]}
-        # threshold=48120 on devserver with gcc11.4
-        # todo(lfq): update once binary size is below 50kb.
-        threshold="51504"
-        if [[ "$size" -le "$threshold" ]]; then
-          echo "Success $size <= $threshold"
-        else
-          echo "Fail $size > $threshold"
-          exit 1
-        fi
-
   test-binary-size-linux:
     name: test-binary-size-linux
     uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
     permissions:
       id-token: write
       contents: read
     strategy:
+      matrix:
+        include:
+          - runner: linux.2xlarge
+            docker-image: executorch-ubuntu-22.04-gcc9
+            threshold: 51504
+          - runner: linux.2xlarge
+            docker-image: executorch-ubuntu-22.04-clang12
+            threshold: 51784
+          - runner: linux.arm64.2xlarge
+            docker-image: executorch-ubuntu-22.04-gcc11-aarch64
+            threshold: 51784
       fail-fast: false
     with:
-      runner: linux.2xlarge
-      docker-image: executorch-ubuntu-22.04-clang12
+      runner: ${{ matrix.runner }}
+      docker-image: ${{ matrix.docker-image }}
       submodules: 'true'
       ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
       timeout: 90
@@ -427,16 +402,13 @@ jobs:
         conda activate "${CONDA_ENV}"
 
         ./install_requirements.sh --use-pt-pinned-commit
-
         # build module for executorch.extension.pybindings.portable_lib
         bash test/build_size_test.sh
         strip cmake-out/test/size_test
         output=$(ls -la cmake-out/test/size_test)
         arr=($output)
         size=${arr[4]}
-        # threshold=48120 on devserver with gcc11.4
-        # todo(lfq): update once binary size is below 50kb.
-        threshold="51784"
+        threshold="${{ matrix.threshold }}"
         if [[ "$size" -le "$threshold" ]]; then
           echo "Success $size <= $threshold"
         else

runtime/executor/pte_data_map.cpp

@@ -35,7 +35,8 @@ PteDataMap::get_data(const char* key) const {
         "Searching for key %s: NamedData at index %zu is null",
         key,
         i);
-    if (strcmp(named_data_->Get(i)->key()->c_str(), key) == 0) {
+
+    if (named_data_->Get(i)->key()->string_view() == key) {
       // Get the segment index.
       size_t segment_index = named_data_->Get(i)->segment_index();