You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[executorch] Suppress wdeprecated warnings on tensor_layout.h and named_data_map.h
Context:
ET_EXPERIMENTAL is tagged with [[deprecated]]. This causes errors when ET_EXPERIMENTAL features are used in core ET and code is built with -Werror. See errors on D67127327.
This diff applies Option1 to 'tensor_layout.h' and Option2 to 'named_data_map.h'
Option 1:
- gate with `#pragma GCC diagnostic ignored "-Wdeprecated-declarations"`, for users of tensor_layout.h and program.h
Option 2:
- use ET_DISABLE_EXPERIMENTAL_ANNOTATION=1, for users of tensor_layout.h and program.h
----
Users
- tensor_layout.h: named_data_map.h
- named_data_map.h: method.h, program.h
Generally, I think we can apply either option1/option2 to `tensor_layout.h`.
For `named_data_map.h`, I think we should apply option2, to make ET_EXPERIMENTAL a no-op, or remove the ET_EXPERIMENTAL annotation to the implementation class. Option 1 would disable deprecation warnings for the entire file.
Differential Revision: [D69145438](https://our.internmc.facebook.com/intern/diff/D69145438/)
[ghstack-poisoned]
0 commit comments