Update on "[ET-VK] Only save_cache the first time"

jorgep31415 · jorgep31415 · commit 29399e5b4ddc · 2024-11-19T12:48:58.000-08:00
Add a check in `save_cache` to return early if the cache file already exists. Currently we append the same cache data to that file which makes no difference to model-load time. Differential Revision: [D66179919](https://our.internmc.facebook.com/intern/diff/D66179919/) [ghstack-poisoned]
diff --git a/backends/vulkan/runtime/vk_api/Pipeline.cpp b/backends/vulkan/runtime/vk_api/Pipeline.cpp
@@ -458,7 +458,7 @@ void ComputePipelineCache::save_cache() {
   if (cache_data_path_.empty()) {
     return;
   }
-  
+
   // Return if file exists; the cache is already saved
   std::ifstream ifile(cache_data_path_);
   if (ifile.good()) {

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ void ComputePipelineCache::save_cache() {`
`458`	`458`	`if (cache_data_path_.empty()) {`
`459`	`459`	`return;`
`460`	`460`	`}`
`461`		`-`
	`461`	`+`
`462`	`462`	`// Return if file exists; the cache is already saved`
`463`	`463`	`std::ifstream ifile(cache_data_path_);`
`464`	`464`	`if (ifile.good()) {`