Skip to content

Commit 29db57b

Browse files
authored
Improve executor_runner cmake instructions (#11773)
### Summary There is a mandatory flag `DEXECUTORCH_BUILD_EXECUTOR_RUNNER` must be turned on in order to build `executor_runner`, but this flag is not explicitly set in our tutorial. Though the default of it is `ON`, it can still be a UX issue when following the tutorial where the flag was toggled `OFF` silently when building for other target like `llama_runner`. ### Test plan CI
1 parent ee7e29f commit 29db57b

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

backends/xnnpack/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ mkdir cmake-out
105105
cmake \
106106
-DCMAKE_INSTALL_PREFIX=cmake-out \
107107
-DCMAKE_BUILD_TYPE=Release \
108+
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=ON \
108109
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
109110
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
110111
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \

docs/source/tutorial-xnnpack-delegate-lowering.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ mkdir cmake-out
154154
cmake \
155155
-DCMAKE_INSTALL_PREFIX=cmake-out \
156156
-DCMAKE_BUILD_TYPE=Release \
157+
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=ON \
157158
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
158159
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
159160
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \

examples/xnnpack/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ mkdir cmake-out
3838
cmake \
3939
-DCMAKE_INSTALL_PREFIX=cmake-out \
4040
-DCMAKE_BUILD_TYPE=Release \
41+
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=ON \
4142
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
4243
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
4344
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \

0 commit comments

Comments
 (0)