Skip to content

Commit 2a87d02

Browse files
committed
Update on "[executorch] Create target for named_data_map"
^ Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) [ghstack-poisoned]
1 parent 9edf8ec commit 2a87d02

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

runtime/core/tensor_layout.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,16 @@ class ET_EXPERIMENTAL TensorLayout final {
7777
scalar_type_(scalar_type),
7878
nbytes_(nbytes) {}
7979
/// The sizes of the tensor.
80-
Span<const int32_t> sizes_;
80+
const Span<const int32_t> sizes_;
8181

8282
/// The dim order of the tensor.
83-
Span<const uint8_t> dim_order_;
83+
const Span<const uint8_t> dim_order_;
8484

8585
/// The scalar type of the tensor.
86-
executorch::aten::ScalarType scalar_type_;
86+
const executorch::aten::ScalarType scalar_type_;
8787

8888
/// The size in bytes of the tensor.
89-
size_t nbytes_;
89+
const size_t nbytes_;
9090
};
9191

9292
} // namespace runtime

runtime/core/test/tensor_layout_test.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ TEST(TestTensorLayout, Ctor) {
2626
Span<const int32_t> sizes_span = {sizes.data(), sizes.size()};
2727
Span<const uint8_t> dim_order_span = {dim_order.data(), dim_order.size()};
2828

29-
Result<TensorLayout> layout_res =
29+
Result<const TensorLayout> layout_res =
3030
TensorLayout::create(sizes_span, dim_order_span, ScalarType::Float);
3131
EXPECT_TRUE(layout_res.ok());
3232

@@ -50,7 +50,7 @@ TEST(TestTensorLayout, Ctor_InvalidDimOrder) {
5050
Span<const int32_t> sizes_span = {sizes.data(), sizes.size()};
5151
Span<const uint8_t> dim_order_span = {dim_order.data(), dim_order.size()};
5252

53-
Result<TensorLayout> layout_res =
53+
Result<const TensorLayout> layout_res =
5454
TensorLayout::create(sizes_span, dim_order_span, ScalarType::Float);
5555
EXPECT_EQ(layout_res.error(), Error::InvalidArgument);
5656
}
@@ -61,7 +61,7 @@ TEST(TestTensorLayout, Ctor_InvalidSizes) {
6161
Span<const int32_t> sizes_span = {sizes.data(), sizes.size()};
6262
Span<const uint8_t> dim_order_span = {dim_order.data(), dim_order.size()};
6363

64-
Result<TensorLayout> layout_res =
64+
Result<const TensorLayout> layout_res =
6565
TensorLayout::create(sizes_span, dim_order_span, ScalarType::Float);
6666
EXPECT_EQ(layout_res.error(), Error::InvalidArgument);
6767
}
@@ -72,7 +72,7 @@ TEST(TestTensorLayout, Ctor_SizesDimOrderMismatch) {
7272
Span<const int32_t> sizes_span = {sizes.data(), sizes.size()};
7373
Span<const uint8_t> dim_order_span = {dim_order.data(), dim_order.size()};
7474

75-
Result<TensorLayout> layout_res =
75+
Result<const TensorLayout> layout_res =
7676
TensorLayout::create(sizes_span, dim_order_span, ScalarType::Float);
7777
EXPECT_EQ(layout_res.error(), Error::InvalidArgument);
7878
}

0 commit comments

Comments
 (0)