Add check for executor runner + minor documentation fixes

Change-Id: I7cc0d06321282824d1af55f027cd15de0ce95b99

Author: AdrianLundell

backends/arm/test/common.py

@@ -17,7 +17,7 @@
 from executorch.backends.arm.arm_backend import ArmCompileSpecBuilder
 from executorch.backends.arm.tosa_specification import TosaSpecification
 from executorch.exir.backend.compile_spec_schema import CompileSpec
-from runner_utils import corstone300_installed, corstone320_installed
+from runner_utils import corstone300_installed, corstone320_installed, RunnerUtil
 
 
 def get_time_formatted_path(path: str, log_prefix: str) -> str:
@@ -163,14 +163,18 @@ def get_target_board(compile_spec: list[CompileSpec]) -> str | None:
 
 
 SkipIfNoCorstone300 = pytest.mark.skipif(
-    not corstone300_installed(), reason="Did not find Corstone-300 FVP on path"
+    not corstone300_installed()
+    or not RunnerUtil.arm_executor_runner_exists("corstone-300"),
+    reason="Did not find Corstone-300 FVP or executor_runner on path",
 )
-""" Marks a test as running on Ethos-U55 FVP, e.g. Corstone 300. Skips the test if this is not installed."""
+"""Skips a test if Corsone300 FVP is not installed, or if the executor runner is not built"""
 
 SkipIfNoCorstone320 = pytest.mark.skipif(
-    not corstone320_installed(), reason="Did not find Corstone-320 FVP on path"
+    not corstone320_installed()
+    or not RunnerUtil.arm_executor_runner_exists("corstone-320"),
+    reason="Did not find Corstone-320 FVP or executor_runner on path",
 )
-""" Marks a test as running on Ethos-U85 FVP, e.g. Corstone 320. Skips the test if this is not installed."""
+"""Skips a test if Corsone320 FVP is not installed, or if the executor runner is not built."""
 
 
 def parametrize(
@@ -185,6 +189,7 @@ def parametrize(
         xfails = {}
 
     def decorator_func(func):
+        """Test data is transformed from a dict of (id, data) pairs to a list of pytest params to work with the native pytests parametrize function"""
         pytest_testsuite = []
         for id, test_parameters in test_data.items():
             if id in xfails:

backends/arm/test/runner_utils.py

@@ -246,6 +246,29 @@ def init_run(
     def set_timeout(self, timeout: int):
         self.timeout = timeout
 
+    @staticmethod
+    def get_elf_path(target_board):
+        elf_path = os.path.join(
+            "cmake-out",
+            f"arm_semihosting_executor_runner_{target_board}",
+            "arm_executor_runner",
+        )
+        if not os.path.exists(elf_path):
+            raise RuntimeError(
+                f"Did not find build arm_executor_runner in path {elf_path}, run setup_testing.sh?"
+            )
+        else:
+            return elf_path
+
+    @staticmethod
+    def arm_executor_runner_exists(target_board):
+        try:
+            RunnerUtil.get_elf_path(target_board)
+        except:
+            return False
+        else:
+            return True
+
     def run_corstone(
         self,
         inputs: Tuple[torch.Tensor],
@@ -272,14 +295,7 @@ def run_corstone(
             input_paths.append(
                 os.path.join(self.intermediate_path, f"{name}.bin"),
             )
-        elf_path = os.path.join(
-            "cmake-out",
-            f"arm_semihosting_executor_runner_{self.target_board}",
-            "arm_executor_runner",
-        )
-        assert os.path.exists(
-            elf_path
-        ), f"Did not find build arm_executor_runner in path {elf_path}, run setup_testing.sh?"
+        elf_path = self.get_elf_path(self.target_board)
 
         cmd_line = f"executor_runner -m {pte_path} -o {out_path}"
 

backends/arm/test/tester/test_pipeline.py

@@ -26,7 +26,7 @@ class BasePipelineMaker(Generic[T]):
         module: The module which the pipeline is applied to.
         test_data: Data used for quantizing and testing the module.
         aten_ops: Aten dialect ops expected to be found in the graph after export.
-        exir_ops: Exir dialect ops expected to be found in the graph after to_edge, re
+        exir_ops: Exir dialect ops expected to be found in the graph after to_edge.
         compile_spec: The compile spec used in the lowering process
         use_edge_to_transform_and_lower: Selects betweeen two possible routes for lowering the module:
                 tester.to_edge_transform_and_lower()