Skip to content

Commit 329a94c

Browse files
committed
Update base for Update on "Reuse GELU implementation from PyTorch core"
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch. Note that, because we will pick up Sleef internally and ignore it externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS. Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break. Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/) [ghstack-poisoned]
1 parent 70b5627 commit 329a94c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

shim/xplat/executorch/build/env_interface.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ def _patch_headers(kwargs):
140140

141141
# header_namespace is to workaround the fact that all C++ source files are having the pattern:
142142
# `include <executorch/.../*.h>` but BUCK2 root is at executorch/ so the `executorch/` prefix is redundant.
143-
kwargs["header_namespace"] = "executorch/" + native.package_name()
143+
if "header_namespace" not in kwargs:
144+
kwargs["header_namespace"] = "executorch/" + native.package_name()
144145
return kwargs
145146

146147
def _patch_pp_flags(kwargs):

0 commit comments

Comments
 (0)