Skip to content

Commit 397b8df

Browse files
jathuJathu Satkunarajah
andauthored
Fix missing kernel header in stack util (#14069)
Summary: Given `stack_util.h` is exported and it includes `kernel_includes.h`, we need `kernel_includes` in the build dependency. One solution is to expect the clients who use `slice_util` to also add `kernel_includes`. However, "doing it for them" via exported_deps seems like a nicer solution. Reviewed By: silverguo Differential Revision: D81930473 Co-authored-by: Jathu Satkunarajah <[email protected]>
1 parent 245630a commit 397b8df

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

kernels/portable/cpu/util/targets.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,8 @@ def define_common_targets():
302302
exported_headers = ["stack_util.h"],
303303
deps = [
304304
"//executorch/kernels/portable/cpu/util:copy_ops_util",
305+
],
306+
exported_deps = [
305307
"//executorch/runtime/kernel:kernel_includes",
306308
],
307309
visibility = ["//executorch/kernels/portable/cpu/...", "@EXECUTORCH_CLIENTS"],

0 commit comments

Comments
 (0)