Skip to content

Commit 3ae007d

Browse files
authored
Remove other extensions' source files from EXTENSION_TRAINING_SRCS and TRAIN_XOR_SRCS (#13433)
Looks like this was an artifact of improperly specified deps in (now deleted) cmake_deps.toml. extension/training/CMakeLists.txt already has the relevant dependencies, so we should be able to just remove these.
1 parent 7c8f637 commit 3ae007d

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

shim_et/xplat/executorch/build/build_variables.bzl

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -370,27 +370,14 @@ THREADPOOL_SRCS = [
370370
EXTENSION_THREADPOOL_SRCS = ["extension/threadpool/" + x for x in THREADPOOL_SRCS]
371371

372372
EXTENSION_TRAINING_SRCS = [
373-
"extension/data_loader/file_data_loader.cpp",
374-
"extension/data_loader/mmap_data_loader.cpp",
375-
"extension/flat_tensor/flat_tensor_data_map.cpp",
376-
"extension/flat_tensor/serialize/flat_tensor_header.cpp",
377-
"extension/module/module.cpp",
378373
"extension/training/module/training_module.cpp",
379374
"extension/training/optimizer/sgd.cpp",
380375
]
381376

382377
TRAIN_XOR_SRCS = [
383-
"extension/data_loader/file_data_loader.cpp",
384-
"extension/data_loader/mmap_data_loader.cpp",
385-
"extension/flat_tensor/flat_tensor_data_map.cpp",
386-
"extension/flat_tensor/serialize/flat_tensor_header.cpp",
378+
# REVIEW: removing this breaks the build; where is it supposed to come from?
387379
"extension/flat_tensor/serialize/serialize.cpp",
388-
"extension/module/module.cpp",
389-
"extension/tensor/tensor_ptr.cpp",
390-
"extension/tensor/tensor_ptr_maker.cpp",
391380
"extension/training/examples/XOR/train.cpp",
392-
"extension/training/module/training_module.cpp",
393-
"extension/training/optimizer/sgd.cpp",
394381
]
395382

396383
EXECUTOR_RUNNER_SRCS = [

0 commit comments

Comments
 (0)