Arm backend: Use correct log-level in tests

Arm tests logged too much as comparisons with logger.level were used
instead of logger.getEffectiveLevel(). logger.level will always be
logging.NOTSET unless explicitly set with logger.setLevel() which we
want to avoid. Instead, we should use logger.getEffectiveLevel() which
will inherit the level from its parent.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: If863593e7dbe455999d5b7bca33cc2511aa3ee50

Author: oscarandersson8218

backends/arm/_passes/decompose_embedding_pass.py

@@ -17,7 +17,6 @@
 from .arm_pass_utils import create_node, get_first_fake_tensor
 
 logger = logging.getLogger(__name__)
-logger.setLevel(logging.WARNING)
 
 
 class DecomposeEmbeddingPass(ArmPass):

backends/arm/operator_support/right_shift_support.py

@@ -48,5 +48,5 @@ def is_node_tosa_supported(
         """
         # TODO MLETORCH-525 Remove warning
         if tosa_spec.is_U55_subset:
-            logging.warning(f"{node.target} may introduce one-off errors.")
+            logger.warning(f"{node.target} may introduce one-off errors.")
         return True

backends/arm/operator_support/slice_copy_support.py

@@ -32,6 +32,6 @@ def is_node_tosa_supported(self, node: fx.Node, tosa_spec: TosaSpecification) ->
 
         args = node.args
         if len(args) == 5 and (step := args[4]) != 1:
-            logging.warning(f"{node.target} with step size of {step} not supported.")
+            logger.warning(f"{node.target} with step size of {step} not supported.")
             return False
         return True

backends/arm/test/conftest.py

@@ -6,11 +6,12 @@
 import logging
 import os
 import random
-import sys
 from typing import Any
 
 import pytest
 
+logger = logging.getLogger(__name__)
+
 """
 This file contains the pytest hooks, fixtures etc. for the Arm test suite.
 """
@@ -29,8 +30,6 @@ def pytest_configure(config):
     if config.option.arm_run_tosa_version:
         pytest._test_options["tosa_version"] = config.option.arm_run_tosa_version
 
-    logging.basicConfig(level=logging.INFO, stream=sys.stdout)
-
 
 def pytest_collection_modifyitems(config, items):
     pass
@@ -98,7 +97,7 @@ def set_random_seed():
                 "ARM_TEST_SEED env variable must be integers or the string RANDOM"
             )
 
-    print(f" ARM_TEST_SEED={seed} ", end=" ")
+    logger.info(f"ARM_TEST_SEED={seed}")
 
 
 # ==== End of Pytest fixtures =====

backends/arm/test/models/test_deit_tiny_arm.py

@@ -23,7 +23,6 @@
 from torchvision import transforms
 
 logger = logging.getLogger(__name__)
-logger.setLevel(logging.INFO)
 
 
 deit_tiny = timm.models.deit.deit_tiny_patch16_224(pretrained=True)

backends/arm/test/runner_utils.py

@@ -763,11 +763,11 @@ def run_tosa_graph(
     if isinstance(tosa_version, Tosa_1_00):
         import tosa_reference_model as reference_model  # type: ignore[import-untyped]
 
-        debug_mode = "ALL" if logger.level <= logging.DEBUG else None
+        debug_mode = "ALL" if logger.getEffectiveLevel() <= logging.DEBUG else None
         outputs_np, status = reference_model.run(
             graph,
             inputs_np,
-            verbosity=_tosa_refmodel_loglevel(logger.level),
+            verbosity=_tosa_refmodel_loglevel(logger.getEffectiveLevel()),
             initialize_variable_tensor_from_numpy=True,
             debug_mode=debug_mode,
         )

backends/arm/test/tester/analyze_output_utils.py

@@ -273,11 +273,8 @@ def dump_error_output(
 
 
 if __name__ == "__main__":
-    import sys
 
-    logging.basicConfig(stream=sys.stdout, level=logging.INFO)
-
-    """ This is expected to produce the example output of print_diff"""
+    """This is expected to produce the example output of print_diff"""
     torch.manual_seed(0)
     a = torch.rand(3, 3, 2, 2) * 0.01
     b = a.clone().detach()