Skip to content

Commit 3daa2ba

Browse files
committed
Patch llava
1 parent 61ebe1e commit 3daa2ba

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

examples/models/llava/runner/llava_image_prefiller.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
namespace example {
1818

19-
using executorch::extension::llm::kImageEncoderMethod;
2019
using executorch::extension::llm::kTextModelMethod;
20+
using executorch::extension::llm::kVisionEncoderMethod;
2121

2222
class ET_EXPERIMENTAL LlavaImagePrefiller {
2323
public:
@@ -39,7 +39,7 @@ class ET_EXPERIMENTAL LlavaImagePrefiller {
3939
::executorch::aten::ScalarType::Byte);
4040
// Run image encoder
4141
auto image_encoder_outputs =
42-
ET_UNWRAP(module_->execute(kImageEncoderMethod, image_tensor));
42+
ET_UNWRAP(module_->execute(kVisionEncoderMethod, image_tensor));
4343

4444
// inputs:[start_pos, embeds]
4545
auto start_pos_tensor = executorch::extension::from_blob(
@@ -67,7 +67,7 @@ class ET_EXPERIMENTAL LlavaImagePrefiller {
6767
if (is_method_loaded()) {
6868
return ::executorch::runtime::Error::Ok;
6969
}
70-
ET_CHECK_OK_OR_RETURN_ERROR(module_->load_method(kImageEncoderMethod));
70+
ET_CHECK_OK_OR_RETURN_ERROR(module_->load_method(kVisionEncoderMethod));
7171
ET_CHECK_OK_OR_RETURN_ERROR(module_->load_method(kTextModelMethod));
7272
return ::executorch::runtime::Error::Ok;
7373
}
@@ -83,7 +83,7 @@ class ET_EXPERIMENTAL LlavaImagePrefiller {
8383
ET_CHECK_MSG(false, "Failed to get method names");
8484
}
8585
std::unordered_set<std::string> methods = methods_res.get();
86-
bool methods_exist = methods.find(kImageEncoderMethod) != methods.end() &&
86+
bool methods_exist = methods.find(kVisionEncoderMethod) != methods.end() &&
8787
methods.find(kTextModelMethod) != methods.end();
8888
if (!methods_exist) {
8989
for (const auto& method : methods) {
@@ -92,10 +92,10 @@ class ET_EXPERIMENTAL LlavaImagePrefiller {
9292
ET_CHECK_MSG(
9393
methods_exist,
9494
"Missing required methods (%s, %s) in the model",
95-
kImageEncoderMethod,
95+
kVisionEncoderMethod,
9696
kTextModelMethod);
9797
}
98-
bool methods_loaded = module_->is_method_loaded(kImageEncoderMethod) &&
98+
bool methods_loaded = module_->is_method_loaded(kVisionEncoderMethod) &&
9999
module_->is_method_loaded(kTextModelMethod);
100100
return methods_loaded;
101101
}

0 commit comments

Comments
 (0)