abstract process id

Author: JacobSzwejbka

backends/cuda/runtime/cuda_backend.cpp

@@ -11,7 +11,6 @@
 #include <executorch/runtime/core/error.h>
 #include <executorch/runtime/core/evalue.h>
 #include <executorch/runtime/core/exec_aten/util/tensor_util.h>
-#include <unistd.h>
 #include <cstdio>
 
 #include <filesystem>
@@ -35,8 +34,7 @@ namespace executorch::backends::cuda {
       return symbol_res.error();                                     \
     }                                                                \
     handle->member = reinterpret_cast<name##Func>(symbol_res.get()); \
-  }                                                                  \
-  while (0)
+  } while (0)
 
 using namespace std;
 using namespace aoti;
@@ -125,7 +123,7 @@ class ET_EXPERIMENTAL CudaBackend final
     // Generate dynamic temporary file path
     filesystem::path temp_dir = filesystem::temp_directory_path();
     filesystem::path so_path =
-        temp_dir / (so_blob_key + to_string(getpid()) + ".so");
+        temp_dir / (so_blob_key + to_string(get_process_id()) + ".so");
 
     // Create a temporary file
     ofstream outfile(so_path.c_str(), ios::binary);

backends/cuda/runtime/platform/platform.h

@@ -7,13 +7,14 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include <string>
 #include <executorch/runtime/core/error.h>
+#include <string>
 
 #ifdef _WIN32
 #include <windows.h>
 #else
 #include <dlfcn.h>
+#include <unistd.h>
 #endif
 
 namespace executorch {
@@ -23,52 +24,75 @@ namespace cuda {
 Result<void*> load_library(const std::string& path) {
 #ifdef _WIN32
   auto lib_handle = LoadLibrary(path.c_str());
-  if (hModule == NULL) {
-      ET_LOG(Error, "Failed to load %s with error: %lu", path.c_str(), GetLastError());
-      return Error::AccessFailed;
+  if (lib_handle == NULL) {
+    ET_LOG(
+        Error,
+        "Failed to load %s with error: %lu",
+        path.c_str(),
+        GetLastError());
+    return Error::AccessFailed;
   }
 
 #else
   void* lib_handle = dlopen(path.c_str(), RTLD_LAZY | RTLD_LOCAL);
-  if (so_handle == nullptr) {
+  if (lib_handle == nullptr) {
     ET_LOG(Error, "Failed to load %s with error: %s", path.c_str(), dlerror());
     return Error::AccessFailed;
   }
 #endif
-  return (void*) lib_handle;
+  return (void*)lib_handle;
 }
 
 Error close_library(void* lib_handle) {
 #ifdef _WIN32
-    if (!FreeLibrary((HModule)lib_handle)) {
-        printf("FreeLibrary failed with error %lu\n", GetLastError());
-        return Error::Internal
-    } 
+  if (!FreeLibrary((HMODULE)lib_handle)) {
+    printf("FreeLibrary failed with error %lu\n", GetLastError());
+    return Error::Internal;
+  }
 #else
   if (dlclose(lib_handle) != 0) {
-      ET_LOG(Error, "dlclose failed: %s\n", dlerror());
-      return Error::Internal;
+    ET_LOG(Error, "dlclose failed: %s\n", dlerror());
+    return Error::Internal;
   }
 #endif
   return Error::Ok;
 }
 
 Result<void*> get_function(void* lib_handle, const std::string& fn_name) {
 #ifdef _WIN32
-  auto fn = GetProcAddress((HModule)lib_handle, fn_name.c_str());
+  auto fn = GetProcAddress((HMODULE)lib_handle, fn_name.c_str());
   if (!fn) {
-      ET_LOG(Error, "Failed loading symbol %s with error %lu\n", fn_name.c_str(), GetLastError());
-      return Error::Internal;
+    ET_LOG(
+        Error,
+        "Failed loading symbol %s with error %lu\n",
+        fn_name.c_str(),
+        GetLastError());
+    return Error::Internal;
   }
 #else
   auto fn = dlsym(lib_handle, fn_name.c_str());
   if (fn == nullptr) {
-      ET_LOG(Error, "Failed loading symbol %s with error %s\n", fn_name.c_str(), dlerror());
-      return Error::Internal;
+    ET_LOG(
+        Error,
+        "Failed loading symbol %s with error %s\n",
+        fn_name.c_str(),
+        dlerror());
+    return Error::Internal;
   }
 #endif
 
-  return (void*)fn; // This I think is technically ub on windows. We should probably explicitly pack the bytes.
+  return (void*)fn; // This I think is technically ub on windows. We should
+                    // probably explicitly pack the bytes.
+}
+
+int32_t get_process_id(void* lib_handle) {
+#ifdef _WIN32
+  return GetCurrentProcessId();
+#else
+  return getpid();
+#endif
+}
+
 }
 
 } // cuda