cmake dll install changes

Author: JacobSzwejbka

backends/cuda/CMakeLists.txt

@@ -49,6 +49,13 @@ if(MSVC)
   add_library(aoti_cuda SHARED ${_aoti_cuda_sources})
   # Define export macro for Windows DLL
   target_compile_definitions(aoti_cuda PRIVATE EXPORT_AOTI_FUNCTIONS)
+  # Ensure proper DLL import/export library naming on Windows
+  set_target_properties(aoti_cuda PROPERTIES
+    WINDOWS_EXPORT_ALL_SYMBOLS OFF  # We use explicit exports via AOTI_CUDA_EXPORT
+    RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin
+    LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib
+    ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib
+  )
 else()
   add_library(aoti_cuda STATIC ${_aoti_cuda_sources})
 endif()
@@ -89,5 +96,7 @@ endif()
 install(
   TARGETS aoti_cuda
   EXPORT ExecuTorchTargets
-  DESTINATION lib
+  LIBRARY DESTINATION lib
+  ARCHIVE DESTINATION lib
+  RUNTIME DESTINATION bin
 )

examples/models/voxtral/CMakeLists.txt

@@ -101,16 +101,6 @@ endif()
 list(APPEND link_libraries tokenizers::tokenizers)
 
 add_executable(voxtral_runner ${_srcs})
-
-# On MSVC, ensure the aoti_cuda DLL is copied to the output directory
-if(EXECUTORCH_BUILD_CUDA AND MSVC)
-  add_custom_command(TARGET voxtral_runner POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E copy_if_different
-      $<TARGET_FILE:aoti_cuda>
-      $<TARGET_FILE_DIR:voxtral_runner>
-    COMMENT "Copying aoti_cuda.dll to output directory"
-  )
-endif()
 if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
   target_link_options_gc_sections(voxtral_runner)
   if(NOT APPLE)