Skip to content

Commit 47b812e

Browse files
committed
review comments
Signed-off-by: Rob Elliott <[email protected]>
1 parent 29eaf47 commit 47b812e

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

backends/arm/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ For more information on TOSA see https://www.mlplatform.org/tosa/tosa_spec.html
1515
**Currently device support is for:**
1616
* TOSA to Ethos&trade;-U55/65/85 via the ethos-u-vela compilation stack.
1717
* This is cross-compiled to the appropriate target CPU
18-
* There is a seperate arm_executor_runner for bare-metal platforms
18+
* There is a separate arm_executor_runner for bare-metal platforms
1919
* TOSA to VGF via the model-converter for devices supporting the ML SDK for Vulkan&reg;
2020
* The VGF graph represents TOSA directly in a SPIR-V&trade; standardized form.
2121
* As the VGF delegate runs on Vulkan, it's required to be built with the Vulkan delegate also present.
@@ -37,7 +37,7 @@ Export:
3737
* `tosa_backend.py` - The TOSA conversion flow all other backends rely on.
3838
* `ethosu/backend.py` - Main entrypoint for the EthosUBackend.
3939
* `vgf_backend.py` - Main entrypoint for VgfBackend.
40-
* For more information see the section on Arm Backend Architecture](#arm-backend-architecture).
40+
* For more information see the section on [Arm Backend Architecture](#arm-backend-architecture).
4141
* `scripts` - For the core scripts which prepare AoT dependencies such as backend compilers.
4242

4343
Passes (which prepare the partitioned graphs for TOSA conversion):
@@ -66,7 +66,7 @@ Other:
6666

6767
## Testing
6868

69-
The tests and related support scripts will test TOSA, Ethos-U and VGF behaviour based on the installed tools. It is expected that the relevant environment preperation has been performed as outlined in the guide available here https://docs.pytorch.org/executorch/main/tutorial-arm.html
69+
The tests and related support scripts will test TOSA, Ethos-U and VGF behaviour based on the installed tools. It is expected that the relevant environment preparation has been performed as outlined in the guide available here https://docs.pytorch.org/executorch/main/tutorial-arm.html
7070

7171
After setup you can run unit tests with the test_arm_baremetal.sh script.
7272

backends/arm/scripts/run_vkml.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ for arg in "$@"; do
4040
esac
4141
done
4242

43-
echo ${model}
44-
if [[ -z ${model} ]]; then "Model name needs to be provided"; exit 1; fi
43+
if [[ -z ${model} ]]; then echo "Model name needs to be provided"; exit 1; fi
4544

4645

4746
# Source the tools
@@ -76,7 +75,7 @@ fi
7675
log_file=$(mktemp)
7776

7877

79-
${runner} -model_path ${model} | tee ${log_file}
78+
${nobuf} ${runner} -model_path ${model} | tee ${log_file}
8079
echo "[${BASH_SOURCE[0]}] execution complete, $?"
8180

8281
# Most of these can happen for bare metal or linx executor_runner runs.

0 commit comments

Comments
 (0)