Skip to content

Commit 4862ba5

Browse files
Veselin Petrovfacebook-github-bot
authored andcommitted
Executorch ops fail to build on macbook M1 due to bad formatting
Summary: ``` .... executorch/kernels/quantized/cpu/embeddingxb.cpp:140:11: error: format specifies type 'char' but the argument has type 'int32_t' (aka 'int') [-Werror,-Wformat] i, ^~ executorch/runtime/platform/assert.h:39:59: note: expanded from macro 'ET_CHECK_MSG' ET_ASSERT_MESSAGE_EMIT(" (%s): " _format, #_cond, ##__VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ executorch/runtime/platform/assert.h:26:9: note: expanded from macro 'ET_ASSERT_MESSAGE_EMIT' ##__VA_ARGS__) ~~^~~~~~~~~~~~ executorch/runtime/platform/log.h:172:13: note: expanded from macro 'ET_LOG' ##__VA_ARGS__); \ ^~~~~~~~~~~ 1 warning and 1 error generated. ``` Reviewed By: dongpujin, manuelcandales Differential Revision: D65156573
1 parent f813b6a commit 4862ba5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

kernels/quantized/cpu/embeddingxb.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ void check_embedding_xbit_args(
134134
for (int32_t i = 0; i < weight_scales.dim(); ++i) {
135135
ET_CHECK_MSG(
136136
opt_weight_zero_points.value().size(i) == weight_scales.size(i),
137-
"Dimension size misatch at dim %" PRId8
137+
"Dimension size misatch at dim %" PRIi32
138138
"Weight_zero_point size = %zd"
139139
", weight_scales size = %zd.",
140140
i,

kernels/quantized/cpu/op_embedding.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ void check_embedding_byte_args(
9393
for (int32_t i = 0; i < weight_scales.dim(); ++i) {
9494
ET_CHECK_MSG(
9595
opt_weight_zero_points.value().size(i) == weight_scales.size(i),
96-
"Dimension size misatch at dim %" PRId8
96+
"Dimension size misatch at dim %" PRIi32
9797
"Weight_zero_point size = %zd"
9898
", weight_scales size = %zd.",
9999
i,

0 commit comments

Comments
 (0)