Arm backend: Improve error logging when running Corstone FVP

Instead of putting the whole FVP runtime command and log in the
runtime error text only a condensed error is used, the command and
the full log is outputed in the log instead.

As we now always log the command and log, you can now look and compare
FVP output logs also on passed test by running run pytests with "-rP".

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I43ebcb235c935265ffd44fa39229e78852f2d4be

Author: zingo

backends/arm/test/runner_utils.py

@@ -477,10 +477,25 @@ def run_corstone(
     # Regex to check for error or fault messages in stdout from FVP
     result_stdout = result.stdout.decode()
     error_regex = r"(^[EF][: ].*$)|(^.*Hard fault.*$)|(^.*Assertion.*$)"
-    if re.compile(error_regex, re.MULTILINE).search(result_stdout):
-        raise RuntimeError(
+    pattern = re.compile(error_regex, re.MULTILINE)
+    regex_matches = [m.group(0) for m in pattern.finditer(result_stdout)]
+
+    if regex_matches:
+        logger.error(
             f"Corstone simulation failed:\ncmd: {' '.join(command_args)}\nlog: \n {result_stdout}\n{result.stderr.decode()}"
         )
+        # Pretty-print regex matches
+        pretty_matches = "\n".join(f"{m.strip()}" for i, m in enumerate(regex_matches))
+        logger.error(
+            f"Corstone simulation failed. Problems: {len(regex_matches)} found:\n{pretty_matches}"
+        )
+        raise RuntimeError(
+            f"Corstone simulation failed. Problems: {len(regex_matches)} found:\n{pretty_matches}"
+        )
+    else:
+        logger.info(
+            f"Corstone simulation:\ncmd: {' '.join(command_args)}\nlog: \n {result_stdout}\n{result.stderr.decode()}"
+        )
 
     return get_output_from_file(exported_program, intermediate_path, output_base_name)