Update on "[ET-VK] Implement prepack nodes"

## Context

This diff implements the idea described in the previous diff in this stack. During export, `et_vk.prepack` nodes will be inserted to convert constant tensors to GPU tensor objects. This makes it so that Vulkan operators will not have to account for the possibility that their arguments can potentially be constant tensor data instead of an actual tensor object.

Differential Revision: [D64603666](https://our.internmc.facebook.com/intern/diff/D64603666/)

[ghstack-poisoned]

Author: SS-JIA

backends/vulkan/runtime/graph/ops/impl/Staging.cpp

@@ -172,7 +172,7 @@ ValueRef prepack_standard_like(
       passthrough);
 }
 
-void add_prepack_direct_buffer_copy_node(
+void add_prepack_direct_copy_buffer_node(
     ComputeGraph& graph,
     const ValueRef tensor_data,
     const ValueRef tensor) {
@@ -203,7 +203,7 @@ ValueRef prepack_direct_copy_buffer(
   VK_CHECK_COND(graph.val_is_tref(tensor_data));
   ValueRef tensor =
       graph.add_tensor_like(tensor_data, utils::kBuffer, utils::kWidthPacked);
-  add_prepack_direct_buffer_copy_node(graph, tensor_data, tensor);
+  add_prepack_direct_copy_buffer_node(graph, tensor_data, tensor);
   return tensor;
 }
 

backends/vulkan/runtime/graph/ops/impl/Staging.h

@@ -39,7 +39,7 @@ void add_tensor_to_staging_node(
  * tensor shader. The created `Tensor` value is then returned.
  *
  * If `passthrough` is `true`, then `v` may be a `Tensor` as well. If `v` is a
- * `Tensor`, then it is returned as-is. If `passthrough` if `false` (default),
+ * `Tensor`, then it is returned as-is. If `passthrough` is `false` (default),
  * then an exception will be thrown.
  */
 

backends/vulkan/test/vulkan_compute_api_test.cpp

@@ -2610,8 +2610,6 @@ void test_binary_op(
 
   IOValueRef arg2{};
 
-  CREATE_WEIGHT_TENSOR(arg2_w, sizes_small, dtype, 2.5f);
-
   // Build graph
 
   IOValueRef arg1 = graph.add_input_tensor(sizes_big, dtype, memory_layout);

examples/portable/custom_ops/custom_ops_1_out.cpp

@@ -20,11 +20,11 @@ void check_preconditions(const Tensor& in, Tensor& out) {
   ET_CHECK_MSG(
       out.scalar_type() == ScalarType::Float,
       "Expected out tensor to have dtype Float, but got %hhd instead",
-      out.scalar_type());
+      static_cast<int8_t>(out.scalar_type()));
   ET_CHECK_MSG(
       in.scalar_type() == ScalarType::Float,
       "Expected in tensor to have dtype Float, but got %hhd instead",
-      in.scalar_type());
+      static_cast<int8_t>(in.scalar_type()));
   ET_CHECK_MSG(
       out.dim() == in.dim(),
       "Number of dims of out tensor is not compatible with inputs");

kernels/test/custom_kernel_example/op_relu.cpp

@@ -87,7 +87,7 @@ my_relu_out(KernelRuntimeContext& context, const Tensor& input, Tensor& out) {
           InvalidArgument,
           out,
           "Unhandled dtype %hhd",
-          input.scalar_type());
+          static_cast<int8_t>(input.scalar_type()));
   }
 #undef RELU