Skip to content

Commit 4a92492

Browse files
committed
Update on "Use c10 version of half/bfloat16 in executorch"
Accomplished by importing relevant files from c10 into executorch/runtime/core/portable_type/c10, and then using `using` in the top-level ExecuTorch headers. This approach should keep the ExecuTorch build hermetic for embedded use cases. In the future, we should add a CI job to ensure the c10 files stay identical to the PyTorch ones. Differential Revision: [D66106969](https://our.internmc.facebook.com/intern/diff/D66106969/) [ghstack-poisoned]
2 parents 3206b93 + 26e3d28 commit 4a92492

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

shim/xplat/executorch/build/env_interface.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def _remove_platform_specific_args(kwargs):
119119
keys = []
120120
for key in kwargs:
121121
if (key.endswith("_platform_preprocessor_flags") or key.endswith("_platform_deps") or
122-
key.startswith("fbobjc") or key.endswith("_platform_compiler_flags")):
122+
key.startswith("fbobjc") or key.endswith("_platform_compiler_flags") or key == "fbcode_exported_preprocessor_flags"):
123123
keys.append(key)
124124
for key in keys:
125125
kwargs.pop(key)

0 commit comments

Comments
 (0)