Skip to content

Commit 5c9a49c

Browse files
committed
Update on "[build] Add editable mode unittest"
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
2 parents e11e41f + 475eb56 commit 5c9a49c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.ci/scripts/setup-linux.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ parse_args "$@"
1515
# As Linux job is running inside a Docker container, all of its dependencies
1616
# have already been installed, so we use PyTorch build from source here instead
1717
# of nightly. This allows CI to test against latest commits from PyTorch
18-
if [[ "$EDITABLE" == "true" ]]; then
19-
install_executorch "--use-pt-pinned-commit" "--editable"
18+
if [[ "${EDITABLE:-false}" == "true" ]]; then
19+
install_executorch --use-pt-pinned-commit --editable
2020
else
21-
install_executorch "--use-pt-pinned-commit"
21+
install_executorch --use-pt-pinned-commit
2222
fi
2323
build_executorch_runner "${BUILD_TOOL}" "${BUILD_MODE}"
2424

.github/workflows/_unittest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
editable:
1919
required: false
2020
type: string
21-
description: Install ExecuTorch in editable or not.
21+
description: Install ExecuTorch in editable mode or not.
2222
python-version:
2323
required: false
2424
type: string

0 commit comments

Comments
 (0)