Skip to content

Commit 5ccdef1

Browse files
SamGondelmanfacebook-github-bot
authored andcommitted
reorganize VOLK_IMPLEMENTATION usage
Summary: when using ETVK with volk, Runtime.cpp should not define VOLK_IMPLEMENTATION, but should instead leave its definition up to clients. this makes combining multiple volk-dependent libraries easier Differential Revision: D87851728
1 parent 33ec615 commit 5ccdef1

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

backends/vulkan/runtime/vk_api/Runtime.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
#include <iostream>
1515
#include <sstream>
1616

17-
#ifdef USE_VOLK_HEADER_ONLY
18-
// For volk.h, define this before including volk.h in exactly one CPP file.
19-
#define VOLK_IMPLEMENTATION
20-
#include <volk.h>
21-
#endif /* USE_VOLK_HEADER_ONLY */
22-
2317
namespace vkcompute {
2418
namespace vkapi {
2519

backends/vulkan/targets.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ def define_common_targets(is_fbcode = False):
192192
else:
193193
for deps in [default_deps, android_deps]:
194194
deps.append("fbsource//third-party/volk:volk-header")
195+
deps.append("fbsource//third-party/volk:volk-implementation")
195196

196197
if is_fbcode:
197198
VK_API_DEPS += [

0 commit comments

Comments
 (0)