Fix baed on comments

- Move and rename param_observer.py to per_channel_param_observer.py
- Add todo to merge qconfig

Author: Joey Tsai

backends/qualcomm/quantizer/observers/param_observer.py renamed to backends/qualcomm/quantizer/observers/per_channel_param_observer.py

@@ -2,7 +2,7 @@
 from torch.ao.quantization.observer import UniformQuantizationObserverBase
 
 
-class ParamObserver(UniformQuantizationObserverBase):
+class PerChannelParamObserver(UniformQuantizationObserverBase):
     def __init__(
         self,
         ch_axis=0,

backends/qualcomm/quantizer/qconfig.py

@@ -270,6 +270,7 @@ def get_ptq_per_channel_quant_config(
     return quantization_config
 
 
+# TODO merge qat and ptq to a fucntion, and use a bool flag to control it
 def get_8a8w_qnn_qat_config(
     act_symmetric: bool = False, act_observer=MovingAverageMinMaxObserver
 ) -> QuantizationConfig:

backends/qualcomm/quantizer/quantizer.py

@@ -22,6 +22,8 @@
 from torch.ao.quantization.quantizer import Quantizer
 from torch.fx import GraphModule
 
+from .annotators import OP_ANNOTATOR
+
 from .qconfig import (
     get_16a16w_qnn_ptq_config,
     get_16a4w_qnn_ptq_config,
@@ -34,8 +36,6 @@
     QuantizationConfig,
 )
 
-from .annotators import OP_ANNOTATOR
-
 __all__ = [
     "QnnQuantizer",
     "QuantDtype",

examples/qualcomm/oss_scripts/fastvit.py

@@ -14,8 +14,8 @@
     QuantizationConfig,
     QuantizationSpec,
 )
-from executorch.backends.qualcomm.quantizer.observers.param_observer import (
-    ParamObserver,
+from executorch.backends.qualcomm.quantizer.observers.per_channel_param_observer import (
+    PerChannelParamObserver,
 )
 from executorch.backends.qualcomm.quantizer.qconfig import (
     _derived_bias_quant_spec,