Skip to content

Commit 5f3a768

Browse files
committed
Update
[ghstack-poisoned]
2 parents a6c69a6 + 675f01b commit 5f3a768

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

build/executorch-config.cmake

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,12 @@ endforeach()
119119

120120
# TODO: investigate use of install(EXPORT) to cleanly handle
121121
# target_compile_options/target_compile_definitions for everything.
122-
if (TARGET cpublas)
122+
if(TARGET extension_parallel)
123+
set_target_properties(
124+
extension_parallel PROPERTIES INTERFACE_LINK_LIBRARIES extension_threadpool
125+
)
126+
endif()
127+
if(TARGET cpublas)
123128
set_target_properties(
124129
cpublas PROPERTIES INTERFACE_LINK_LIBRARIES extension_parallel
125130
)

examples/models/llama/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# ~~~
1616
# It should also be cmake-lint clean.
1717
#
18-
cmake_minimum_required(VERSION 3.19)
18+
cmake_minimum_required(VERSION 3.24) # 3.24 is required for WHOLE_ARCHIVE
1919
project(llama_runner)
2020

2121
# Duplicating options as root CMakeLists.txt
@@ -111,7 +111,7 @@ target_link_options_shared_lib(quantized_ops_lib)
111111
list(APPEND link_libraries quantized_kernels quantized_ops_lib)
112112

113113
if(EXECUTORCH_BUILD_KERNELS_CUSTOM)
114-
list(APPEND link_libraries custom_ops)
114+
list(APPEND link_libraries $<LINK_LIBRARY:WHOLE_ARCHIVE,custom_ops>)
115115
endif()
116116

117117
if(EXECUTORCH_BUILD_TORCHAO)

0 commit comments

Comments
 (0)