Reset temp allocator before instruction

Summary:
If the temp allocator is defined, then it now (after some more recent changes) has objects allocated after 'init'. It doesn't seem to be cleared before the first instruction. Our temp allocator was very precisely bound to the size of a resource being allocated in our delegate and the leftover state in the temp allocator caused a failure to allocate.

We'll just clear this allocator wherever it's used.

Reviewed By: abhiag-git, JacobSzwejbka

Differential Revision: D80191057

Author: cmt0

runtime/executor/method.cpp

@@ -754,6 +754,12 @@ Error Method::resolve_operator(
     return op_function.error();
   }
   kernels[kernel_index] = op_function.get();
+
+  // If we used the temp allocator here, reset it.
+  if (allocator == memory_manager_->temp_allocator()) {
+    memory_manager_->temp_allocator()->reset();
+  }
+
   return Error::Ok;
 }
 
@@ -1547,6 +1553,9 @@ Error Method::execute() {
         i);
   }
   ET_LOG(Debug, "Executing method: %s.", method_meta().name());
+  if (temp_allocator_ != nullptr) {
+    temp_allocator_->reset();
+  }
 
   // Chains are executed sequentially today, but future async designs may
   // branch and run many in parallel or out of order.

runtime/executor/test/kernel_integration_test.cpp

@@ -367,8 +367,9 @@ TEST_F(KernelTempMemoryAllocatorIntegrationTest, UsingTempMemoryAllocator) {
   EXPECT_EQ(control_->total_allocated_size, 4);
   EXPECT_EQ(temp_allocator_->number_of_allocations, 1);
   EXPECT_EQ(temp_allocator_->total_allocated_size, 4);
-  // The temp allocator should have been reset after the execution.
-  EXPECT_EQ(temp_allocator_->number_of_resets, 1);
+  // The temp allocator should have been reset after the execution and before
+  // method execution.
+  EXPECT_EQ(temp_allocator_->number_of_resets, 2);
   EXPECT_EQ(temp_allocator_->currently_allocated_size, 0);
 
   control_->temp_memory_size = 8;
@@ -379,6 +380,6 @@ TEST_F(KernelTempMemoryAllocatorIntegrationTest, UsingTempMemoryAllocator) {
   EXPECT_EQ(temp_allocator_->number_of_allocations, 2);
   EXPECT_EQ(temp_allocator_->total_allocated_size, 12);
   // The temp allocator should have been reset after the execution.
-  EXPECT_EQ(temp_allocator_->number_of_resets, 2);
+  EXPECT_EQ(temp_allocator_->number_of_resets, 4);
   EXPECT_EQ(temp_allocator_->currently_allocated_size, 0);
 }