Skip to content

Commit 62024d8

Browse files
kirklandsignfacebook-github-bot
authored andcommitted
Use ms for number report (#5362)
Summary: ns * 1e-6 = ms Example output: (9.36ms inference mv2_xnnpack) ``` [{"actualValue":9.3611927,"benchmarkModel":{"backend":"","name":"mv2_xnnpack","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"avg_inference_latency(ms)","targetValue":0.0},{"actualValue":27.418698,"benchmarkModel":{"backend":"","name":"mv2_xnnpack","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"model_load_time(ms)","targetValue":0.0},{"actualValue":0.0,"benchmarkModel":{"backend":"","name":"mv2_xnnpack","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"load_status","targetValue":0.0}] ``` and for LLM (12.34 tps mocked number) ``` [{"actualValue":0.0,"benchmarkModel":{"backend":"","name":"et_exported_llama","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"load_status","targetValue":0.0},{"actualValue":3375.450312,"benchmarkModel":{"backend":"","name":"et_exported_llama","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"model_load_time(ms)","targetValue":0.0},{"actualValue":8220.467966,"benchmarkModel":{"backend":"","name":"et_exported_llama","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"generate_time(ms)","targetValue":0.0},{"actualValue":12.3456,"benchmarkModel":{"backend":"","name":"et_exported_llama","quantization":""},"deviceInfo":{"arch":"SM-S926U1","availMem":0,"device":"samsung","os":"Android 14","totalMem":0},"metric":"token_per_sec","targetValue":0.0}] ``` Pull Request resolved: #5362 Reviewed By: huydhn Differential Revision: D62665456 Pulled By: kirklandsign fbshipit-source-id: 3d2444d90aef82bd5f331838a89319be9e9797e5
1 parent 25168b7 commit 62024d8

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

examples/demo-apps/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/LlmBenchmarkRunner.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,15 @@ public void onGenerationStopped() {
105105
results.add(
106106
new BenchmarkMetric(
107107
benchmarkModel,
108-
"model_load_time(ns)",
109-
mStatsDump.loadEnd - mStatsDump.loadStart,
108+
"model_load_time(ms)",
109+
(mStatsDump.loadEnd - mStatsDump.loadStart) * 1e-6,
110110
0.0f));
111111
// LLM generate time
112112
results.add(
113113
new BenchmarkMetric(
114114
benchmarkModel,
115-
"generate_time(ns)",
116-
mStatsDump.generateEnd - mStatsDump.generateStart,
115+
"generate_time(ms)",
116+
(mStatsDump.generateEnd - mStatsDump.generateStart) * 1e-6,
117117
0.0f));
118118
// Token per second
119119
results.add(

extension/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ protected void onCreate(Bundle savedInstanceState) {
5656
for (int i = 0; i < numIter; i++) {
5757
long start = System.nanoTime();
5858
module.forward();
59-
long forwardMs = System.nanoTime() - start;
59+
double forwardMs = (System.nanoTime() - start) * 1e-6;
6060
stats.latency.add(forwardMs);
6161
}
6262

@@ -68,13 +68,13 @@ protected void onCreate(Bundle savedInstanceState) {
6868
results.add(
6969
new BenchmarkMetric(
7070
benchmarkModel,
71-
"avg_inference_latency(ns)",
71+
"avg_inference_latency(ms)",
7272
stats.latency.stream().mapToDouble(l -> l).average().orElse(0.0f),
7373
0.0f));
7474
// Model load time
7575
results.add(
7676
new BenchmarkMetric(
77-
benchmarkModel, "model_load_time(ns)", stats.loadEnd - stats.loadStart, 0.0f));
77+
benchmarkModel, "model_load_time(ms)", (stats.loadEnd - stats.loadStart) * 1e-6, 0.0f));
7878
// Load status
7979
results.add(new BenchmarkMetric(benchmarkModel, "load_status", stats.errorCode, 0));
8080

@@ -90,7 +90,7 @@ protected void onCreate(Bundle savedInstanceState) {
9090
class Stats {
9191
long loadStart;
9292
long loadEnd;
93-
List<Long> latency = new ArrayList<>();
93+
List<Double> latency = new ArrayList<>();
9494
int errorCode = 0;
9595

9696
@Override

extension/android/benchmark/app/src/main/java/org/pytorch/minibench/LlmBenchmarkActivity.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,15 @@ public void onGenerationStopped() {
9797
results.add(
9898
new BenchmarkMetric(
9999
benchmarkModel,
100-
"model_load_time(ns)",
101-
mStatsInfo.loadEnd - mStatsInfo.loadStart,
100+
"model_load_time(ms)",
101+
(mStatsInfo.loadEnd - mStatsInfo.loadStart) * 1e-6,
102102
0.0f));
103103
// LLM generate time
104104
results.add(
105105
new BenchmarkMetric(
106106
benchmarkModel,
107-
"generate_time(ns)",
108-
mStatsInfo.generateEnd - mStatsInfo.generateStart,
107+
"generate_time(ms)",
108+
(mStatsInfo.generateEnd - mStatsInfo.generateStart) * 1e-6,
109109
0.0f));
110110
// Token per second
111111
results.add(

0 commit comments

Comments
 (0)