Update on "Use c10 version of half/bfloat16 in executorch"

Github Executorch · Github Executorch · commit 69e2672769c4 · 2025-01-10T09:43:15.000-08:00
Accomplished by importing relevant files from c10 into executorch/runtime/core/portable_type/c10, and then using `using` in the top-level ExecuTorch headers. This approach should keep the ExecuTorch build hermetic for embedded use cases. In the future, we should add a CI job to ensure the c10 files stay identical to the PyTorch ones. Differential Revision: [D66106969](https://our.internmc.facebook.com/intern/diff/D66106969/) [ghstack-poisoned]
diff --git a/backends/apple/coreml/CMakeLists.txt b/backends/apple/coreml/CMakeLists.txt
@@ -135,7 +135,7 @@ target_include_directories(
 )
 target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/..)
 target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/runtime/core/portable_type)
-target_compile_definitions(coremldelegate C10_USING_CUSTOM_GENERATED_MACROS)
+target_compile_definitions(coremldelegate PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)
 target_link_libraries(coremldelegate PRIVATE executorch_core)
 
 if(EXECUTORCH_BUILD_DEVTOOLS)

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ target_include_directories(`
`135`	`135`	`)`
`136`	`136`	`target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/..)`
`137`	`137`	`target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/runtime/core/portable_type)`
`138`		`-target_compile_definitions(coremldelegate C10_USING_CUSTOM_GENERATED_MACROS)`
	`138`	`+target_compile_definitions(coremldelegate PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)`
`139`	`139`	`target_link_libraries(coremldelegate PRIVATE executorch_core)`
`140`	`140`
`141`	`141`	`if(EXECUTORCH_BUILD_DEVTOOLS)`