Skip to content

Commit 76f500e

Browse files
author
Github Executorch
committed
Remove redundant example test targets
Not every op has a portable version, and there are portable tests explicitly listed in this config so these are redundant. Differential Revision: [D69495125](https://our.internmc.facebook.com/intern/diff/D69495125/) ghstack-source-id: 265941893 Pull Request resolved: #8395
1 parent 8d96d74 commit 76f500e

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

kernels/test/targets.bzl

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,6 @@ def _common_op_test(name, kernels):
1010
deps = [":function_header_wrapper_{}".format(kernel)]
1111
op_test(name, kernel_name = kernel, use_kernel_prefix = True, deps = deps)
1212

13-
def make_example_generated_op_test_target():
14-
"""
15-
Makes a test for kernels/test/util generated_op_test() helper
16-
Here we use portable kernel. Try with `buck test xplat/executorch/kernels/test:op_<>_test`
17-
"""
18-
op_test_cpp_files = native.glob(
19-
["op_*_test.cpp"],
20-
# linear has no portable op.
21-
exclude = ["op_linear_test.cpp"],
22-
)
23-
24-
# The op name is from the beginning to the part without `_test.cpp` (:-9)
25-
op_to_test = [f[:-9] for f in op_test_cpp_files]
26-
for op_name in op_to_test:
27-
generated_op_test(
28-
op_name + "_test",
29-
"//executorch/kernels/portable/cpu:{}".format(op_name),
30-
"//executorch/kernels/portable:generated_lib_headers",
31-
"//executorch/kernels/portable/test:supported_features",
32-
"//executorch/kernels/test:function_header_wrapper_portable",
33-
)
34-
3513
def define_common_targets():
3614
"""Defines targets that should be shared between fbcode and xplat.
3715
@@ -353,5 +331,3 @@ def define_common_targets():
353331
_common_op_test("op_view_copy_test", ["aten", "portable"])
354332
_common_op_test("op_where_test", ["aten", "portable"])
355333
_common_op_test("op_zeros_test", ["aten", "portable"])
356-
357-
make_example_generated_op_test_target()

0 commit comments

Comments
 (0)