Skip to content

Commit 77425a5

Browse files
committed
Add a notation for private device
And also enable Apple benchmark there. This depends on pytorch/test-infra#6579 Signed-off-by: Huy Do <[email protected]>
1 parent fa89efa commit 77425a5

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

.github/scripts/extract_benchmark_results.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,8 @@ def transform(
349349
# Overwrite the device name here with the job name as it has more information about
350350
# the device, i.e. Samsung Galaxy S22 5G instead of just Samsung
351351
for r in benchmark_results:
352-
r["deviceInfo"]["device"] = job_name
352+
is_private_device = job_report.get("is_private_instance", False)
353+
r["deviceInfo"]["device"] = f"{job_name} (private)" if is_private_device else job_name
353354

354355
# From https://github.com/pytorch/pytorch/wiki/How-to-integrate-with-PyTorch-OSS-benchmark-database
355356
return [

.github/workflows/apple-perf-private-device-experiment.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
name: apple-perf (private devices)
22

33
on:
4-
# TODO (huydhn): Disable the schedule run until we land the change to add device pool and device name
5-
# to separate between public and private iOS devices
6-
# schedule:
7-
# - cron: 0 0,4,8,12,16,20 * * *
4+
schedule:
5+
- cron: 0 0,4,8,12,16,20 * * *
86
pull_request:
97
paths:
108
- .github/workflows/apple-perf-private-device-experiment.yml
11-
# push:
12-
# branches:
13-
# - main
14-
# paths:
15-
# - .github/workflows/apple-perf-private-device-experiment.yml
9+
push:
10+
branches:
11+
- main
12+
paths:
13+
- .github/workflows/apple-perf-private-device-experiment.yml
1614
# Note: GitHub has an upper limit of 10 inputs
1715
workflow_dispatch:
1816
inputs:

.github/workflows/apple-perf.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,8 @@ jobs:
436436
permissions:
437437
id-token: write
438438
contents: read
439-
uses: pytorch/test-infra/.github/workflows/mobile_job.yml@main
439+
# TESTING
440+
uses: pytorch/test-infra/.github/workflows/mobile_job.yml@add-device-type-and-id
440441
strategy:
441442
matrix: ${{ fromJson(needs.set-parameters.outputs.benchmark_configs) }}
442443
fail-fast: false
@@ -446,7 +447,8 @@ jobs:
446447
device-type: ios
447448
# For iOS testing, the runner just needs to call AWS Device Farm, so there is no need to run this on macOS
448449
runner: linux.2xlarge
449-
test-infra-ref: ''
450+
# TESTING
451+
test-infra-ref: add-device-type-and-id
450452
# This is the ARN of ExecuTorch project on AWS
451453
project-arn: arn:aws:devicefarm:us-west-2:308535385114:project:02a2cf0f-6d9b-45ee-ba1a-a086587469e6
452454
device-pool-arn: ${{ matrix.device_arn }}

0 commit comments

Comments
 (0)