Update on "[ET-VK] Adding get or create int function to read int value."

This diff adds a new function `get_or_create_int` to the `ComputeGraph` class, which allows reading an integer value from a `ValueRef` index. The function returns the extracted integer value if the value at the index is an integer, otherwise it throws an error. Additionally, an overload of the function is added to return a default value if the value at the index is `None`.

Differential Revision: [D78094858](https://our.internmc.facebook.com/intern/diff/D78094858/)

[ghstack-poisoned]

Author: trivedivivek

backends/vulkan/runtime/graph/ComputeGraph.cpp

@@ -549,15 +549,6 @@ vkapi::BufferBindInfo ComputeGraph::get_or_create_int_param_buffer(
   }
 }
 
-int32_t ComputeGraph::get_or_create_int(
-    const ValueRef idx,
-    const int32_t default_val) {
-  if (values_.at(idx).isNone()) {
-    return default_val;
-  }
-  return extract_scalar<int32_t>(idx);
-}
-
 void ComputeGraph::set_symint(const ValueRef idx, const int32_t val) {
   get_symint(idx)->set(val);
 }

backends/vulkan/runtime/graph/ComputeGraph.h

@@ -424,7 +424,7 @@ class ComputeGraph final {
   // Scalar Value Extraction
   //
 
-  bool is_scalar(const ValueRef idx) const {
+  bool is_scalar_or_none(const ValueRef idx) const {
     const Value& value = values_.at(idx);
     return value.isInt() || value.isDouble() || value.isBool() ||
         value.isNone();
@@ -445,6 +445,15 @@ class ComputeGraph final {
     VK_THROW("Cannot extract scalar from Value with type ", value.type());
   }
 
+  template <typename T>
+  T extract_scalar_or(const ValueRef idx, const T default_value) {
+    Value& value = values_.at(idx);
+    if (value.isNone()) {
+      return default_value;
+    }
+    return extract_scalar<T>(idx);
+  }
+
   template <typename T>
   std::optional<T> extract_optional_scalar(const ValueRef idx) {
     if (val_is_none(idx)) {
@@ -685,8 +694,6 @@ class ComputeGraph final {
       const ValueRef idx,
       const int32_t default_value);
 
-  int32_t get_or_create_int(const ValueRef idx, const int32_t default_value);
-
   void set_symint(const ValueRef idx, const int32_t val);
 
   int32_t read_symint(const ValueRef idx);