You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
refactor no longer needed EXECUTORCH_BUILD_HOST_TARGETS (#10320)
### Summary
Removes EXECUTORCH_BUILD_HOST_TARGETS per @mergennachin
[comment](#9306 (review)).
Fixes#9404
### Test plan
Ensure executorch and cadence builds successfully:
```
./install_executorch.sh
mkdir cmake-out
cmake -DCMAKE_TOOLCHAIN_FILE=backends/cadence/cadence.cmake \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DCMAKE_BUILD_TYPE=Debug \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_HOST_TARGETS=ON \
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
-DEXECUTORCH_BUILD_PTHREADPOOL=OFF \
-DEXECUTORCH_BUILD_CPUINFO=OFF \
-Bcmake-out .
cmake --build cmake-out -j8 --target install --config Debug
cmake -DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_TOOLCHAIN_FILE=examples/backends/cadence.cmake \
-DCMAKE_PREFIX_PATH=cmake-out \
-DMODEL_PATH=add.pte \
-DNXP_SDK_ROOT_DIR=/home/user_name/nxp-sdk \
-DNN_LIB_BASE_DIR=/home/user_name/nnlib-hifi4 \
-Bcmake-out/examples/cadence \
examples/cadence
cmake --build cmake-out/examples/cadence -j8 -t cadence_executorch_example
ls cmake-xt/*.bin
```
* Test plan assumes nxp-sdk and nnlib-hifir are in user's home directory
and Xtensa compiler is available (env vars set). See [cadence
docs](https://github.com/pytorch/executorch/blob/main/docs/source/backends-cadence.md)
* Since these are modifications to the build system, I leave it to
discretion if CI builds provide enough risk protection to merge.
* Happy to write tests if needed - I'll need a little direction here if
needed. #9306 ran `./install_executorch.sh`, `build_apple_frameworks.sh`
and `build_android_library.sh`.
---------
Co-authored-by: Mergen Nachin <[email protected]>
0 commit comments