Commit 7783ade
refactor no longer needed EXECUTORCH_BUILD_HOST_TARGETS (#10320)
### Summary
Removes EXECUTORCH_BUILD_HOST_TARGETS per @mergennachin
[comment](#9306 (review)).
Fixes #9404
### Test plan
Ensure executorch and cadence builds successfully:
```
./install_executorch.sh
mkdir cmake-out
cmake -DCMAKE_TOOLCHAIN_FILE=backends/cadence/cadence.cmake \
-DCMAKE_INSTALL_PREFIX=cmake-out \
-DCMAKE_BUILD_TYPE=Debug \
-DPYTHON_EXECUTABLE=python3 \
-DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \
-DEXECUTORCH_BUILD_HOST_TARGETS=ON \
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
-DEXECUTORCH_BUILD_PTHREADPOOL=OFF \
-DEXECUTORCH_BUILD_CPUINFO=OFF \
-Bcmake-out .
cmake --build cmake-out -j8 --target install --config Debug
cmake -DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_TOOLCHAIN_FILE=examples/backends/cadence.cmake \
-DCMAKE_PREFIX_PATH=cmake-out \
-DMODEL_PATH=add.pte \
-DNXP_SDK_ROOT_DIR=/home/user_name/nxp-sdk \
-DNN_LIB_BASE_DIR=/home/user_name/nnlib-hifi4 \
-Bcmake-out/examples/cadence \
examples/cadence
cmake --build cmake-out/examples/cadence -j8 -t cadence_executorch_example
ls cmake-xt/*.bin
```
* Test plan assumes nxp-sdk and nnlib-hifir are in user's home directory
and Xtensa compiler is available (env vars set). See [cadence
docs](https://github.com/pytorch/executorch/blob/main/docs/source/backends-cadence.md)
* Since these are modifications to the build system, I leave it to
discretion if CI builds provide enough risk protection to merge.
* Happy to write tests if needed - I'll need a little direction here if
needed. #9306 ran `./install_executorch.sh`, `build_apple_frameworks.sh`
and `build_android_library.sh`.
---------
Co-authored-by: Mergen Nachin <[email protected]>1 parent 5f59b76 commit 7783ade
File tree
5 files changed
+2
-40
lines changed- backends/cadence
- docs/source
- tools/cmake
5 files changed
+2
-40
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | 413 | | |
428 | 414 | | |
429 | 415 | | |
| |||
458 | 444 | | |
459 | 445 | | |
460 | 446 | | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | 447 | | |
472 | 448 | | |
473 | 449 | | |
| |||
665 | 641 | | |
666 | 642 | | |
667 | 643 | | |
668 | | - | |
669 | | - | |
670 | | - | |
671 | | - | |
| 644 | + | |
672 | 645 | | |
673 | 646 | | |
674 | 647 | | |
| |||
692 | 665 | | |
693 | 666 | | |
694 | 667 | | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
| 668 | + | |
699 | 669 | | |
700 | 670 | | |
701 | 671 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| |||
65 | 64 | | |
66 | 65 | | |
67 | 66 | | |
68 | | - | |
69 | 67 | | |
70 | 68 | | |
71 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
| |||
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
66 | | - | |
67 | 65 | | |
68 | 66 | | |
69 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
174 | 173 | | |
175 | 174 | | |
176 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | 96 | | |
100 | 97 | | |
101 | 98 | | |
| |||
0 commit comments