Skip to content

Commit 7c3741f

Browse files
committed
Add end
1 parent a7e4f49 commit 7c3741f

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

devtools/etdump/etdump_flatcc.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ Result<EventTracerEntry> ETDumpGen::start_profiling_delegate(
251251
return Result<EventTracerEntry>(prof_entry);
252252
}
253253

254-
void ETDumpGen::end_profiling_delegate(
254+
Result<bool> ETDumpGen::end_profiling_delegate(
255255
EventTracerEntry event_tracer_entry,
256256
const void* metadata,
257257
size_t metadata_len) {
@@ -282,6 +282,7 @@ void ETDumpGen::end_profiling_delegate(
282282
etdump_RunData_events_push_start(builder_);
283283
etdump_Event_profile_event_add(builder_, id);
284284
etdump_RunData_events_push_end(builder_);
285+
return Result<bool>(true);
285286
}
286287

287288
Result<bool> ETDumpGen::log_profiling_delegate(

devtools/etdump/etdump_flatcc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class ETDumpGen : public ::executorch::runtime::EventTracer {
8686
virtual Result<::executorch::runtime::EventTracerEntry> start_profiling_delegate(
8787
const char* name,
8888
DelegateDebugIntId delegate_debug_index) override;
89-
virtual void end_profiling_delegate(
89+
virtual Result<bool> end_profiling_delegate(
9090
::executorch::runtime::EventTracerEntry prof_entry,
9191
const void* metadata,
9292
size_t metadata_len) override;

docs/source/delegate-debugging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ To conclude an `EventTracerEntry`, `event_tracer_end_profiling_delegate` is simp
100100
Optionally, additional runtime `metadata` can also be logged at this point.
101101

102102
```c++
103-
void event_tracer_end_profiling_delegate(
103+
Result<bool> event_tracer_end_profiling_delegate(
104104
EventTracer* event_tracer,
105105
EventTracerEntry event_tracer_entry,
106106
const void* metadata = nullptr,

runtime/core/event_tracer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class EventTracer {
235235
* make it available for the user again in the post-processing stage.
236236
* @param[in] metadata_len Length of the metadata buffer.
237237
*/
238-
virtual void end_profiling_delegate(
238+
virtual Result<bool> end_profiling_delegate(
239239
EventTracerEntry event_tracer_entry,
240240
const void* metadata = nullptr,
241241
size_t metadata_len = 0) = 0;

runtime/core/test/event_tracer_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class DummyEventTracer : public EventTracer {
8282
return Result<EventTracerEntry>(EventTracerEntry());
8383
}
8484

85-
void end_profiling_delegate(
85+
Result<bool> end_profiling_delegate(
8686
ET_UNUSED EventTracerEntry event_tracer_entry,
8787
ET_UNUSED const void* metadata,
8888
ET_UNUSED size_t metadata_len) override {

0 commit comments

Comments
 (0)