Skip to content

Commit 7fdd05d

Browse files
author
zhenyanzhang
committed
Update on "[ExecuTorch][#10375] Add extension.BundledModule to Wrap extension.Module with Bundled Program Logic"
#10375 # Context This issue is a step of #9638. In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`. The issue is that `pybindings.PyModule` is dependent on the `method` getter from `pybindings.Module`, which `extension.Module` do not have. Since we don't want to expose `method` getter in `extension.Module`, we have to protect the getter, wrap the functions that is dependent on it and use the protected getter there, ultimately decouple `pybindings` from a `method` getter. # Proposal Now that we have a protected `method` getter, we can introduce a `extension.BundledModule`, a child class inheriting `extension.Module` which wraps up bundled program logic that is dependent on the `method` getter. Differential Revision: [D73564125](https://our.internmc.facebook.com/intern/diff/D73564125/) [ghstack-poisoned]
1 parent f6ba0bd commit 7fdd05d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extension/module/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def define_common_targets():
2323
],
2424
deps = [
2525
"//executorch/extension/data_loader:buffer_data_loader",
26-
"//executorch/devtools/bundled_program:runtime",
26+
"//executorch/devtools/bundled_program:runtime" + aten_suffix,
2727
"//executorch/devtools/bundled_program/schema:bundled_program_schema_fbs",
2828
"//executorch/extension/memory_allocator:malloc_memory_allocator",
2929
"//executorch/extension/data_loader:file_data_loader",

0 commit comments

Comments
 (0)