-
Notifications
You must be signed in to change notification settings - Fork 712
Commit 843fa18
committed
Update base for Update on "[Executorch][custom ops] Change lib loading logic to account for package dir"
Just looking at the location of the source file. In this case custom_ops.py,
can, and does, yield to wrong location depending on where you import custom_ops
from.
If you are importing custom_ops from another source file inside extension
folder, e.g. builder.py that is in extensions/llm/export, then, I think,
custom_ops gets resolved to the one installed in site-packages or pip package.
But if this is imported from say
examples/models/llama/source_transformations/quantized_kv_cache.py (Like in the
in next PR), then it seems to resolve to the source location. In one of the CI
this is /pytorch/executorch.
Now depending on which directory your filepath resolves to, you will search for
lib in that. This of course does not work when filepath resolves to source
location.
This PR changes that to resolve to package location.
Differential Revision: [D66385480](https://our.internmc.facebook.com/intern/diff/D66385480/)
[ghstack-poisoned]1 parent 7bdbcfa commit 843fa18Copy full SHA for 843fa18
File tree
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
0 commit comments