-
Notifications
You must be signed in to change notification settings - Fork 706
Commit 880f674
committed
Update base for Update on "Use unlifted export pass to tag delegated constants"
Use the unlifted pass to tag constants for delegates.
Implications:
- Tagging must happen on the unlifted ep.module(), before going into to_edge_transform_and_lower/to_edge.
Why?
- The unlifted graph contains constants in getattr nodes, which is a convenient way to isolate constants.
- After going into to_edge_transform_and_lower/to_edge, transforms happen on the graph_module, which is lifted.
- The lifted graph requires the ep graph signature to differentiate constants via the `is_param` function. However, in to_edge.transform, we do not have access to the ep. Baking the ep as an argument via partial function doesn't work, as the ep from earlier may be outdated. This means we are comparing an older ep to a newer graph_module, which may not have corresponding graph signatures etc.
Differential Revision: [D79736684](https://our.internmc.facebook.com/intern/diff/D79736684/)
[ghstack-poisoned]1 parent 239e20c commit 880f674Copy full SHA for 880f674
File tree
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
0 file changed
+0
-0
lines changedOpen diff view settings
0 commit comments