Skip to content

Commit 89f3e39

Browse files
huydhnfacebook-github-bot
authored andcommitted
Allow each model to choose its own runner (#277)
Summary: It's a good idea to allow each model to choose its own runner. This also help unblock #212 until we know the root cause of why it runs OOM. Pull Request resolved: #277 Reviewed By: kirklandsign Differential Revision: D49176509 Pulled By: huydhn fbshipit-source-id: b5e74943fb62839e3b9a7ff132842c8614d0f84b
1 parent 0c1d726 commit 89f3e39

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.ci/scripts/gather_test_models.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
"buck2",
1717
"cmake",
1818
]
19+
DEFAULT_RUNNER = "linux.2xlarge"
20+
RUNNERS = {
21+
# This one runs OOM on smaller runner, the root cause is unclear (T163016365)
22+
"w2l": "linux.12xlarge"
23+
}
1924

2025

2126
def set_output(name: str, val: Any) -> None:
@@ -53,6 +58,7 @@ def export_models_for_ci() -> None:
5358
"model": name,
5459
"quantization": quantization,
5560
"xnnpack_delegation": xnnpack_delegation,
61+
"runner": RUNNERS.get(name, DEFAULT_RUNNER),
5662
}
5763
)
5864
set_output("models", json.dumps(models))

.github/workflows/pull.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
matrix: ${{ fromJSON(needs.gather-models.outputs.models) }}
4444
fail-fast: false
4545
with:
46-
runner: linux.2xlarge
46+
runner: ${{ matrix.runner }}
4747
docker-image: executorch-ubuntu-22.04-clang12
4848
submodules: 'true'
4949
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
@@ -99,7 +99,7 @@ jobs:
9999
- build-tool: cmake
100100
fail-fast: false
101101
with:
102-
runner: linux.2xlarge
102+
runner: ${{ matrix.runner }}
103103
docker-image: executorch-ubuntu-22.04-clang12
104104
submodules: 'true'
105105
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
@@ -148,7 +148,7 @@ jobs:
148148
- build-tool: cmake
149149
fail-fast: false
150150
with:
151-
runner: linux.2xlarge
151+
runner: ${{ matrix.runner }}
152152
docker-image: executorch-ubuntu-22.04-clang12
153153
submodules: 'true'
154154
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}

0 commit comments

Comments
 (0)