wip ∫ MAY 20 2025 16:19:09

Author: jathu

.github/workflows/build-presets.yml

@@ -66,3 +66,24 @@ jobs:
         ./install_requirements.sh > /dev/null
         cmake --preset ${{ matrix.preset }}
         cmake --build cmake-out --parallel
+
+  windows:
+    uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
+    strategy:
+      fail-fast: false
+      matrix:
+        preset: [pybind]
+    with:
+      job-name: build
+      ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
+      submodules: recursive
+      timeout: 90
+      script: |
+        set -eux
+
+        conda create --yes --quiet -n et python=3.12
+        conda activate et
+
+        ./install_requirements.sh > /dev/null
+        cmake --preset ${{ matrix.preset }}
+        cmake --build cmake-out --parallel

CMakeLists.txt

@@ -67,12 +67,19 @@ if(NOT CMAKE_BUILD_TYPE)
 endif()
 announce_configured_options(CMAKE_BUILD_TYPE)
 
+if(WIN32)
+  if(CMAKE_CXX_COMPILER AND NOT CMAKE_CXX_COMPILER MATCHES ".*clang.*")
+    message(FATAL_ERROR "CMAKE_CXX_COMPILER must be set to clang on Windows")
+  endif()
+endif()
+announce_configured_options(CMAKE_C_COMPILER_ID)
+announce_configured_options(CMAKE_CXX_COMPILER_ID)
+
 if(NOT PYTHON_EXECUTABLE)
   resolve_python_executable()
 endif()
 announce_configured_options(PYTHON_EXECUTABLE)
 
-announce_configured_options(CMAKE_CXX_COMPILER_ID)
 announce_configured_options(CMAKE_TOOLCHAIN_FILE)
 announce_configured_options(BUCK2)
 

CMakePresets.json

@@ -4,7 +4,11 @@
     {
       "name": "common",
       "hidden": true,
-      "binaryDir": "${sourceDir}/cmake-out"
+      "binaryDir": "${sourceDir}/cmake-out",
+      "cacheVariables": {
+        "CMAKE_C_COMPILER": "clang",
+        "CMAKE_CXX_COMPILER": "clang++"
+      }
     },
     {
       "name": "macos-arm64",

install_executorch.py

@@ -221,12 +221,6 @@ def main(args):
         # latest PT commit otherwise
         use_pytorch_nightly = False
 
-    # Use ClangCL on Windows.
-    # ClangCL is an alias to Clang that configures it to work in an MSVC-compatible
-    # mode. Using it on Windows to avoid compiler compatibility issues for MSVC.
-    if os.name == "nt":
-        cmake_args.append("-T ClangCL")
-
     #
     # Install executorch pip package. This also makes `flatc` available on the path.
     # The --extra-index-url may be necessary if pyproject.toml has a dependency on a