Skip to content

Commit 8d28f1c

Browse files
digantdesaifacebook-github-bot
authored andcommitted
Memory format WIP note
Summary: As title Reviewed By: kimishpatel Differential Revision: D47922118 fbshipit-source-id: 219c06a4a23939fad0dada067aba2e5851716c60
1 parent f747ff9 commit 8d28f1c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/website/docs/ir_spec/00_exir.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -564,9 +564,7 @@ NOTE: The concept of pytree is the same as the one documented here for JAX: [htt
564564

565565
### Memory formats
566566

567-
Possible memory formats:
568-
569-
We use the term **Pytorch Default Dims Format **describe the memory format represented by `torch.contiguous_format. `In other words, Let N, C, H, W be number of images, channel, height and weight, then `torch.contiguous_format `will tensor dimensions be in NCHW ordering.
567+
We use the term **Pytorch Default Dims Order** to describe the memory format represented by `torch.contiguous_format`. In other words, Let N, C, H, W be number of images, channel, height and weight, then `torch.contiguous_format `will tensor dimensions be in NCHW ordering.
570568

571569
Other memory formats available in torch are: torch.channels_last: = NHWC
572570

@@ -603,6 +601,8 @@ Other permutations of NCHW are allowed but we don’t have explicit names for th
603601

604602
See more on channel_last mem format: [https://pytorch.org/tutorials/intermediate/memory_format_tutorial.html](https://pytorch.org/tutorials/intermediate/memory_format_tutorial.html)
605603

604+
For Executorch, we have introduced a concept of dim orders to convey how a dense tensor is laid out in memory. Tensor's memory layout and memory format representation using the dim order in the Executorch the stack is still a WIP. We will update this doc and the IR spec very shortly.
605+
606606
### Tensor
607607
A Tensor type describes a mathematical tensor.
608608
Let `t` be a Tensor, then, conceptually `t` provides the following interfaces:

0 commit comments

Comments
 (0)