Skip to content

Commit 95c6cd7

Browse files
author
Github Executorch
committed
Auto-upgrade device pool for ANE
1 parent 184b020 commit 95c6cd7

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

.ci/scripts/gather_benchmark_configs.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
# Device pools for AWS Device Farm
1818
DEVICE_POOLS = {
1919
"apple_iphone_15": "arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/3b5acd2e-92e2-4778-b651-7726bafe129d",
20+
"apple_iphone_15+ios_18": "arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/12c8b15c-8d03-4e07-950d-0a627e7595b4",
2021
"samsung_galaxy_s22": "arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/e59f866a-30aa-4aa1-87b7-4510e5820dfa",
2122
"samsung_galaxy_s24": "arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/98f8788c-2e25-4a3c-8bb2-0d1e8897c0db",
2223
"google_pixel_8_pro": "arn:aws:devicefarm:us-west-2:308535385114:devicepool:02a2cf0f-6d9b-45ee-ba1a-a086587469e6/d65096ab-900b-4521-be8b-a3619b69236a",
@@ -197,10 +198,17 @@ def get_benchmark_configs() -> Dict[str, Dict]:
197198

198199
# Add configurations for each valid device
199200
for device in devices:
200-
if device not in DEVICE_POOLS:
201-
logging.warning(f"Unsupported device '{device}'. Skipping.")
202-
continue
203201
for config in configs:
202+
if config == "llama3_coreml_ane" and not device.endswith("+ios_18"):
203+
device = f"{device}+ios_18"
204+
logging.info(
205+
f"Benchmark config '{config}' only works on iOS 18+, auto-upgraded device pool to '{device}'"
206+
)
207+
208+
if device not in DEVICE_POOLS:
209+
logging.warning(f"Unsupported device '{device}'. Skipping.")
210+
continue
211+
204212
record = {
205213
"model": model_name,
206214
"config": config,

extension/llm/export/partitioner_lib.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,11 @@ def _validate_ios_version() -> None:
158158
op_linear_quantizer_config=op_linear_quantizer_config,
159159
)
160160

161-
take_over_mutable_buffer = minimum_deployment_target >= ct.target.iOS18
161+
# ExecuTorch does not build CoreML delegate runtime to handle state
162+
# when using OSS scripts, so we define take_over_mutable_buffer = False,
163+
# even when target is iOS18
164+
# take_over_mutable_buffer = minimum_deployment_target >= ct.target.iOS18
165+
take_over_mutable_buffer = False
162166
return CoreMLPartitioner( # pyre-fixme[16]
163167
compile_specs=compile_specs,
164168
take_over_mutable_buffer=take_over_mutable_buffer,

0 commit comments

Comments
 (0)