Skip to content

Commit 9741c7a

Browse files
author
Github Executorch
committed
Update on "Fix optimized log_softmax along non-contiguous dim"
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
2 parents 86984f4 + a05e382 commit 9741c7a

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

extension/flat_tensor/serialize/targets.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ def define_common_targets():
3939
name = "flat_tensor_header",
4040
srcs = ["flat_tensor_header.cpp"],
4141
exported_headers = ["flat_tensor_header.h"],
42-
visibility = ["//executorch/..."],
42+
visibility = [
43+
"//executorch/...",
44+
],
4345
exported_deps = ["//executorch/runtime/core:core"],
4446
)
4547

@@ -54,6 +56,7 @@ def define_common_targets():
5456
exported_headers = ["serialize.h"],
5557
visibility = [
5658
"//executorch/...",
59+
"@EXECUTORCH_CLIENTS",
5760
],
5861
exported_external_deps = ["flatbuffers-api"],
5962
)

kernels/test/op_log_softmax_test.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ class OpLogSoftmaxOutTest : public OperatorTest {
7777
void test_dtype_noncontiguous_dim() {
7878
TensorFactory<DTYPE> tf;
7979

80-
// clang-format off Dim 0 must be longer than the vector width of
81-
// the machine (for float, this is 4 for ARM64 and 8 for AVX2) to
82-
// exhibit problems.
80+
// Dim 0 must be longer than the vector width of the machine (for
81+
// float, this is 4 for ARM64 and 8 for AVX2) to exhibit problems.
82+
// clang-format off
8383
Tensor x = tf.make(
8484
{9, 3},
8585
{
@@ -125,7 +125,6 @@ class OpLogSoftmaxOutTest : public OperatorTest {
125125
EXPECT_TENSOR_CLOSE(out, expected);
126126
}
127127
}
128-
129128
};
130129

131130
TEST_F(OpLogSoftmaxOutTest, Smoke) {

0 commit comments

Comments
 (0)