Skip to content

Commit 98f28ff

Browse files
authored
remove sleef_arm target
Differential Revision: D74356413 Pull Request resolved: #11082
1 parent ff81664 commit 98f28ff

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

kernels/optimized/lib_defs.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ def get_vec_deps():
3737
# various ovr_configs are not available in oss
3838
deps = select({
3939
"ovr_config//os:iphoneos-arm64": [
40-
"fbsource//third-party/sleef:sleef_arm",
40+
"fbsource//third-party/sleef:sleef",
4141
] if not runtime.is_oss else [],
4242
"ovr_config//os:macos-arm64": [
43-
"fbsource//third-party/sleef:sleef_arm",
43+
"fbsource//third-party/sleef:sleef",
4444
] if not runtime.is_oss else [],
4545
"ovr_config//os:android-arm64": [
46-
"fbsource//third-party/sleef:sleef_arm",
46+
"fbsource//third-party/sleef:sleef",
4747
] if not runtime.is_oss else [],
4848
"DEFAULT": [],
4949
})
@@ -141,7 +141,7 @@ def define_libs(is_fbcode=False):
141141
(
142142
DEVSERVER_PLATFORM_REGEX,
143143
[
144-
"fbsource//third-party/sleef:sleef_arm",
144+
"fbsource//third-party/sleef:sleef",
145145
],
146146
),
147147
],
@@ -150,7 +150,7 @@ def define_libs(is_fbcode=False):
150150
(
151151
"^android-arm64.*$",
152152
[
153-
"fbsource//third-party/sleef:sleef_arm",
153+
"fbsource//third-party/sleef:sleef",
154154
],
155155
),
156156
],

runtime/core/portable_type/c10/c10/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def define_common_targets():
5757
exported_deps = select({
5858
"DEFAULT": [],
5959
"ovr_config//cpu:arm64": [
60-
"fbsource//third-party/sleef:sleef_arm",
60+
"fbsource//third-party/sleef:sleef",
6161
] if not runtime.is_oss else [],
6262
# fbsource//third-party/sleef:sleef currently fails to
6363
# link with missing symbols, hence the fbcode-specific dep below.

shim_et/xplat/executorch/codegen/codegen.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ def build_optimized_lib(name, oplist_header_name, portable_header_lib, feature =
530530
(
531531
"^android-arm64.*$",
532532
[
533-
"fbsource//third-party/sleef:sleef_arm",
533+
"fbsource//third-party/sleef:sleef",
534534
],
535535
),
536536
],
@@ -646,12 +646,12 @@ def executorch_generated_lib(
646646
if not expose_operator_symbols and not is_xplat():
647647
# TODO(T225169282): make this a fail once internal cases move to xplat.
648648
warning("""
649-
Dtype selective build with expose_operator_symbols=False works only in xplat -
649+
Dtype selective build with expose_operator_symbols=False works only in xplat -
650650
there are undefined symbols otherwise. Please try to use xplat, or talk to the
651651
executorch team. Setting expose_operator_symbols=True is not recommended as the
652652
exposed symbols may clash (duplicate symbols errors) if multiple
653653
executorch_generated_libs are included by a parent library.
654-
654+
655655
Falling back to operator selective build.""")
656656

657657
if (not "//executorch/kernels/portable:operators" in kernel_deps) and (not "//executorch/kernels/optimized:optimized_operators" in kernel_deps):

shim_et/xplat/executorch/kernels/optimized/lib_defs.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@ def get_vec_deps():
4444
"fbsource//third-party/sleef:sleef",
4545
] if not runtime.is_oss else [],
4646
"ovr_config//os:iphoneos": [
47-
"fbsource//third-party/sleef:sleef_arm",
47+
"fbsource//third-party/sleef:sleef",
4848
] if not runtime.is_oss else [],
4949
"ovr_config//os:macos-arm64": [
50-
"fbsource//third-party/sleef:sleef_arm",
50+
"fbsource//third-party/sleef:sleef",
5151
] if not runtime.is_oss else [],
5252
"ovr_config//os:android-arm64": [
53-
"fbsource//third-party/sleef:sleef_arm",
53+
"fbsource//third-party/sleef:sleef",
5454
] if not runtime.is_oss else [],
5555
"DEFAULT": [],
5656
})
@@ -104,7 +104,7 @@ def define_libs():
104104
(
105105
DEVSERVER_PLATFORM_REGEX,
106106
[
107-
"fbsource//third-party/sleef:sleef_arm",
107+
"fbsource//third-party/sleef:sleef",
108108
],
109109
),
110110
],
@@ -113,7 +113,7 @@ def define_libs():
113113
(
114114
"^android-arm64.*$",
115115
[
116-
"fbsource//third-party/sleef:sleef_arm",
116+
"fbsource//third-party/sleef:sleef",
117117
],
118118
),
119119
],

shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def define_op_library(name, compiler_flags, deps):
118118
(
119119
"^android-arm64.*$",
120120
[
121-
"fbsource//third-party/sleef:sleef_arm",
121+
"fbsource//third-party/sleef:sleef",
122122
],
123123
),
124124
],

0 commit comments

Comments
 (0)