Update

[ghstack-poisoned]

Author: swolchok

install_requirements.py

@@ -76,6 +76,9 @@ def clean():
     print("Done cleaning build artifacts.")
 
 
+VALID_PYBINDS = ["coreml", "mps", "xnnpack"]
+
+
 def main(args):
     if not python_is_compatible():
         sys.exit(1)
@@ -105,6 +108,11 @@ def main(args):
         help="build from the pinned PyTorch commit instead of nightly",
     )
     args = parser.parse_args(args)
+
+    if args.clean:
+        clean()
+        return
+
     if args.pybind:
         # Flatten list of lists.
         args.pybind = list(itertools.chain(*args.pybind))
@@ -116,15 +124,13 @@ def main(args):
             EXECUTORCH_BUILD_PYBIND = "OFF"
         else:
             for pybind_arg in args.pybind:
-                if pybind_arg not in ["coreml", "mps", "xnnpack"]:
-                    continue
+                if pybind_arg not in VALID_PYBINDS:
+                    raise Exception(
+                        f"Unrecognized pybind argument {pybind_arg}; valid options are: {", ".join(VALID_PYBINDS)}"
+                    )
                 EXECUTORCH_BUILD_PYBIND = "ON"
                 CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON"
 
-    if args.clean:
-        clean()
-        return
-
     if args.use_pt_pinned_commit:
         # This option is used in CI to make sure that PyTorch build from the pinned commit
         # is used instead of nightly. CI jobs wouldn't be able to catch regression from the