ExecutorchRuntimeException: Update the exception return type (#14483)

Summary:
Fix the JNI layer at the time of throwing the exception. Change the
return type from 'ExecutorchRuntimeException' to 'RuntimeException'

Also disable readLogBuffer from exception flow , A follow up change will
address this. This way it keeps this change to a minimum and unblocks
few Teams for now

Differential Revision: D82995994

(cherry picked from commit 00ea1b7)

Author: psiddh

extension/android/executorch_android/src/main/java/org/pytorch/executorch/ExecutorchRuntimeException.java

@@ -75,6 +75,7 @@ public class ExecutorchRuntimeException extends RuntimeException {
   }
 
   static class ErrorHelper {
+    private static final boolean ENABLE_READ_LOG_BUFFER = false;
     // Reusable StringBuilder instance
     private static final StringBuilder sb = new StringBuilder();
 
@@ -92,14 +93,15 @@ static String formatMessage(int errorCode, String details) {
             .append("] ")
             .append(baseMessage)
             .append(": ")
-            .append(details)
-            .append("\nDetailed Logs:\n");
-
-        try {
-          String[] logEntries = readLogBuffer(); // JNI call
-          formatLogEntries(sb, logEntries);
-        } catch (Exception e) {
-          sb.append("Failed to retrieve detailed logs: ").append(e.getMessage());
+            .append(details);
+        if (ENABLE_READ_LOG_BUFFER) {
+          try {
+            sb.append("\nDetailed Logs:\n");
+            String[] logEntries = readLogBuffer(); // JNI call
+            formatLogEntries(sb, logEntries);
+          } catch (Exception e) {
+            sb.append("Failed to retrieve detailed logs: ").append(e.getMessage());
+          }
         }
 
         return sb.toString();

extension/android/jni/jni_helper.cpp

@@ -19,11 +19,12 @@ void throwExecutorchException(uint32_t errorCode, const std::string& details) {
       "org/pytorch/executorch/ExecutorchRuntimeException");
 
   // Find the static factory method: makeExecutorchException(int, String)
-  static auto makeExceptionMethod = exceptionClass->getStaticMethod<
-      facebook::jni::local_ref<facebook::jni::JThrowable>(
-          int, facebook::jni::alias_ref<facebook::jni::JString>)>(
-      "makeExecutorchException",
-      "(ILjava/lang/String;)Lorg/pytorch/executorch/ExecutorchRuntimeException;");
+  static auto makeExceptionMethod =
+      exceptionClass
+          ->getStaticMethod<facebook::jni::local_ref<facebook::jni::JThrowable>(
+              int, facebook::jni::alias_ref<facebook::jni::JString>)>(
+              "makeExecutorchException",
+              "(ILjava/lang/String;)Ljava/lang/RuntimeException;");
 
   auto jDetails = facebook::jni::make_jstring(details);
   // Call the factory method to create the exception object