Skip to content

Commit 9c12e69

Browse files
authored
Remove LlavaRunner (#14356)
### Summary Following up on [#14250](#14250), remove LlavaRunner (and llava_runner library dependency) ### Test plan Llava CI test
1 parent 108d29d commit 9c12e69

File tree

10 files changed

+3
-591
lines changed

10 files changed

+3
-591
lines changed

examples/models/llava/CMakeLists.txt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,7 @@ list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
7979
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
8080
executorch_target_link_options_shared_lib(executorch)
8181

82-
# llava_runner library
83-
add_subdirectory(runner)
84-
85-
set(LINK_LIBS executorch gflags)
82+
set(LINK_LIBS executorch gflags extension_llm_runner)
8683
set(link_libraries ${LINK_LIBS})
8784
set(_srcs main.cpp)
8885

@@ -204,5 +201,5 @@ if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
204201
endif()
205202

206203
target_include_directories(llava_main PUBLIC ${_common_include_directories})
207-
target_link_libraries(llava_main PUBLIC llava_runner ${link_libraries})
204+
target_link_libraries(llava_main PUBLIC ${link_libraries})
208205
target_compile_options(llava_main PUBLIC ${_common_compile_options})

examples/models/llava/runner/CMakeLists.txt

Lines changed: 0 additions & 46 deletions
This file was deleted.

examples/models/llava/runner/llava_image_prefiller.h

Lines changed: 0 additions & 107 deletions
This file was deleted.

examples/models/llava/runner/llava_runner.cpp

Lines changed: 0 additions & 191 deletions
This file was deleted.

0 commit comments

Comments
 (0)