Update

[ghstack-poisoned]

Author: swolchok

examples/portable/custom_ops/CMakeLists.txt

@@ -123,7 +123,8 @@ list(TRANSFORM _executor_runner__srcs PREPEND "${EXECUTORCH_ROOT}/")
 
 add_executable(custom_ops_executor_runner ${_executor_runner__srcs})
 target_link_libraries(
-  custom_ops_executor_runner custom_ops_lib executorch gflags
+  custom_ops_executor_runner custom_ops_lib executorch extension_evalue_util
+  extension_runner_util gflags
 )
 target_compile_options(
   custom_ops_executor_runner PUBLIC ${_common_compile_options}

examples/selective_build/CMakeLists.txt

@@ -33,7 +33,9 @@ if(NOT CMAKE_CXX_STANDARD)
   # Can't set to 11 due to executor_runner.cpp make_unique
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC -ffunction-sections -fdata-sections)
+set(_common_compile_options -Wno-deprecated-declarations -fPIC
+                            -ffunction-sections -fdata-sections
+)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
@@ -43,7 +45,9 @@ find_package(
   gflags REQUIRED PATHS ${CMAKE_CURRENT_BINARY_DIR}/../../third-party
 )
 
-target_include_directories(executorch_core INTERFACE ${_common_include_directories})
+target_include_directories(
+  executorch_core INTERFACE ${_common_include_directories}
+)
 
 # ------------------------------ OPTIONS BEGIN -------------------------------
 
@@ -63,12 +67,13 @@ option(EXECUTORCH_SELECT_ALL_OPS
 )
 
 # Option to enable parsing ops and dtypes directly from model pte file
-option(EXECUTORCH_SELECT_OPS_FROM_MODEL "Enable op selection from pte during build." OFF
+option(EXECUTORCH_SELECT_OPS_FROM_MODEL
+       "Enable op selection from pte during build." OFF
 )
 
-# Option to enable dtype selective build. Note: must be using selective build model API.
-option(EXECUTORCH_DTYPE_SELECTIVE_BUILD "Enable dtype selective build." OFF
-)
+# Option to enable dtype selective build. Note: must be using selective build
+# model API.
+option(EXECUTORCH_DTYPE_SELECTIVE_BUILD "Enable dtype selective build." OFF)
 # ------------------------------- OPTIONS END --------------------------------
 
 #
@@ -155,7 +160,8 @@ if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
   target_link_options_gc_sections(selective_build_test)
 endif()
 target_link_libraries(
-  selective_build_test PRIVATE executorch_core gflags select_build_lib
+  selective_build_test PRIVATE executorch_core extension_evalue_util
+                               extension_runner_util gflags select_build_lib
 )
 executorch_target_link_options_shared_lib(select_build_lib)
 target_compile_options(selective_build_test PUBLIC ${_common_compile_options})

extension/evalue_util/print_evalue.cpp

@@ -39,8 +39,8 @@ int get_edge_items_xalloc() {
 
 /// Returns the number of "edge items" to print at the beginning and end of
 /// lists when using the provided stream.
-long get_stream_edge_items(std::ostream& os) {
-  long edge_items = os.iword(get_edge_items_xalloc());
+size_t get_stream_edge_items(std::ostream& os) {
+  size_t edge_items = os.iword(get_edge_items_xalloc());
   return edge_items <= 0 ? kDefaultEdgeItems : edge_items;
 }
 
@@ -78,21 +78,20 @@ void print_scalar_list(
     executorch::aten::ArrayRef<T> list,
     bool print_length = true,
     bool elide_inner_items = true) {
-  long edge_items = elide_inner_items ? get_stream_edge_items(os)
-                                      : std::numeric_limits<long>::max();
+  size_t edge_items = elide_inner_items ? get_stream_edge_items(os)
+                                        : std::numeric_limits<long>::max();
   if (print_length) {
     os << "(len=" << list.size() << ")";
   }
 
   // See if we'll be printing enough elements to cause us to wrap.
   bool wrapping = false;
   {
-    long num_printed_items;
+    size_t num_printed_items;
     if (elide_inner_items) {
-      num_printed_items =
-          std::min(static_cast<long>(list.size()), edge_items * 2);
+      num_printed_items = std::min(list.size(), edge_items * 2);
     } else {
-      num_printed_items = static_cast<long>(list.size());
+      num_printed_items = list.size();
     }
     wrapping = num_printed_items > kItemsPerLine;
   }

tools/cmake/executorch-config.cmake

@@ -71,6 +71,7 @@ set(lib_list
     qnn_executorch_backend
     portable_ops_lib
     custom_ops
+    extension_evalue_util
     extension_module
     extension_module_static
     extension_runner_util