Update on "[devtool] make ETDumpGen use datasink"

This diff enables customized debug data pipeline by making ETDumpGen leverage user-provided datasink.

Details can be found in https://docs.google.com/document/d/1y_m32mKdj-OgLcLUz9TKhBW3PC3bBDYSBbeAH544EfM/edit?tab=t.0#heading=h.jlkcrurw482r

Differential Revision: [D69647096](https://our.internmc.facebook.com/intern/diff/D69647096/)

[ghstack-poisoned]

Author: Gasoonjia

devtools/etdump/buffer_data_sink.h

@@ -33,8 +33,9 @@ class BufferDataSink : public DataSinkBase {
   explicit BufferDataSink(::executorch::runtime::Span<uint8_t> buffer)
       : debug_buffer_(buffer), offset_(0) {}
 
-/**
-   * Constructs a BufferDataSink with a given ptr to data blob, and the size of data blob.
+  /**
+   * Constructs a BufferDataSink with a given ptr to data blob, and the size of
+   * data blob.
    *
    * @param[in] ptr A pointer to the data blob where data will be stored.
    * @param[in] size The size of the data blob in bytes.
@@ -47,7 +48,6 @@ class BufferDataSink : public DataSinkBase {
   BufferDataSink(BufferDataSink&&) = default;
   BufferDataSink& operator=(BufferDataSink&&) = default;
 
-
   /**
    * Write data into the debug buffer and return the offset of the starting
    * location of the data within the buffer.

devtools/etdump/etdump_flatcc.cpp

@@ -29,8 +29,8 @@ using ::executorch::runtime::DebugHandle;
 using ::executorch::runtime::DelegateDebugIdType;
 using ::executorch::runtime::EValue;
 using ::executorch::runtime::EventTracerEntry;
-using ::executorch::runtime::Result;
 using ::executorch::runtime::LoggedEValueType;
+using ::executorch::runtime::Result;
 using ::executorch::runtime::Span;
 using ::executorch::runtime::Tag;
 
@@ -379,7 +379,6 @@ void ETDumpGen::log_intermediate_output_delegate_helper(
   } else if constexpr (std::is_same<T, ArrayRef<Tensor>>::value) {
     etdump_Tensor_vec_start(builder_);
     for (size_t i = 0; i < output.size(); ++i) {
-
       long offset = write_tensor_or_raise_error(output[i]);
       etdump_Tensor_vec_push(
           builder_, add_tensor_entry(builder_, output[i], offset));
@@ -633,14 +632,21 @@ size_t ETDumpGen::get_debug_buffer_size() const {
 size_t ETDumpGen::get_data_sink_size() const {
   ET_CHECK_MSG(data_sink_, "Must set data sink before checking its size\n");
   Result<size_t> ret = data_sink_->get_storage_size();
-  ET_CHECK_MSG(ret.ok(), "Failed to get storage size with error 0x%" PRIx32, static_cast<uint32_t>(ret.error()));
+  ET_CHECK_MSG(
+      ret.ok(),
+      "Failed to get storage size with error 0x%" PRIx32,
+      static_cast<uint32_t>(ret.error()));
   return ret.get();
 }
 
 long ETDumpGen::write_tensor_or_raise_error(Tensor tensor) {
   ET_CHECK_MSG(data_sink_, "Must set data sink before writing data\n");
-  Result<size_t> ret = data_sink_->write(tensor.const_data_ptr(), tensor.nbytes());
-  ET_CHECK_MSG(ret.ok(), "Failed to write tensor with error 0x%" PRIx32, static_cast<uint32_t>(ret.error()));
+  Result<size_t> ret =
+      data_sink_->write(tensor.const_data_ptr(), tensor.nbytes());
+  ET_CHECK_MSG(
+      ret.ok(),
+      "Failed to write tensor with error 0x%" PRIx32,
+      static_cast<uint32_t>(ret.error()));
   return static_cast<long>(ret.get());
 }
 

devtools/etdump/etdump_flatcc.h

@@ -173,7 +173,7 @@ class ETDumpGen : public ::executorch::runtime::EventTracer {
       ::executorch::runtime::DebugHandle delegate_debug_index,
       const T& output);
 
-    long write_tensor_or_raise_error(executorch::aten::Tensor tensor);
+  long write_tensor_or_raise_error(executorch::aten::Tensor tensor);
 
   struct flatcc_builder* builder_;
   size_t num_blocks_ = 0;