Skip to content

Commit a02ba23

Browse files
pytorchbotswolchok
andauthored
Re-enable optimized gelu test in CMake (#8667)
* Fix log_softmax along non-contiguous dim Pull Request resolved: #8595 #8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. ghstack-source-id: 268149462 @exported-using-ghexport Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) * Re-enable optimized gelu test in CMake Pull Request resolved: #8597 I missed this line disabling the test. (Splitting out re-enable of log_softmax because I think that one needs fixes.) ghstack-source-id: 268149463 @exported-using-ghexport Differential Revision: [D69929122](https://our.internmc.facebook.com/intern/diff/D69929122/) --------- Co-authored-by: Scott Wolchok <[email protected]>
1 parent 34906b8 commit a02ba23

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

kernels/test/CMakeLists.txt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ foreach(kernel ${_kernels})
6666
cp
6767
"${CMAKE_CURRENT_BINARY_DIR}/../../kernels/${kernel}/${kernel}_ops_lib/*.h"
6868
"${CMAKE_CURRENT_BINARY_DIR}/include/${kernel}/executorch/kernels/${kernel}/"
69-
DEPENDS "${kernel}_ops_lib"
69+
DEPENDS "${kernel}_ops_lib"
7070
)
7171
endforeach()
7272

@@ -278,10 +278,8 @@ set(_optimized_kernels_test_sources
278278
${CMAKE_CURRENT_BINARY_DIR}/include/portable/executorch/kernels/test/supported_features.cpp
279279
)
280280

281-
# We don't have sleef on OSS so we don't have gelu and log_softmax
282-
list(REMOVE_ITEM _optimized_kernels_test_sources "op_gelu_test.cpp"
283-
"op_log_softmax_test.cpp"
284-
)
281+
# We don't have sleef on OSS so we don't have log_softmax
282+
list(REMOVE_ITEM _optimized_kernels_test_sources "op_log_softmax_test.cpp")
285283

286284
et_cxx_test(
287285
optimized_kernels_test

0 commit comments

Comments
 (0)