Skip to content

Commit a1fbac2

Browse files
committed
Update base for Update on "[ExecuTorch][#10447] Extend PyBundledModule with extension.BundledModule"
# Context This issue is a step of #9638. In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`. # Proposal Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/) [ghstack-poisoned]
1 parent b036ff0 commit a1fbac2

File tree

4 files changed

+1
-6
lines changed

4 files changed

+1
-6
lines changed

extension/module/bundled_module.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include <executorch/extension/data_loader/buffer_data_loader.h>
1414
#include <executorch/extension/data_loader/file_data_loader.h>
1515

16-
1716
namespace executorch {
1817
namespace extension {
1918

@@ -28,7 +27,6 @@ std::unique_ptr<BufferDataLoader> program_data_loader(
2827
}
2928
} // namespace
3029

31-
3230
namespace ET_BUNDLED_MODULE_NAMESPACE {
3331

3432
BundledModule::BundledModule(

extension/module/bundled_module.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
#include <executorch/extension/module/module.h>
1212

13-
1413
#ifdef USE_ATEN_LIB
1514
#define ET_BUNDLED_MODULE_NAMESPACE bundled_module::aten
1615
#else // !USE_ATEN_LIB

extension/module/module.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ namespace executorch {
3838
namespace extension {
3939
namespace ET_MODULE_NAMESPACE {
4040

41-
4241
using ET_RUNTIME_NAMESPACE::MethodMeta;
4342
using ET_RUNTIME_NAMESPACE::Program;
4443

extension/module/module.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#include <executorch/runtime/executor/program.h>
1818

19-
2019
#ifdef USE_ATEN_LIB
2120
#define ET_MODULE_NAMESPACE module::aten
2221
#else // !USE_ATEN_LIB
@@ -515,7 +514,7 @@ namespace executor {
515514
// TODO(T197294990): Remove these deprecated aliases once all users have moved
516515
// to the new `::executorch` namespaces.
517516
using ::executorch::extension::ET_MODULE_NAMESPACE::Module;
518-
} // namespace executorch
517+
} // namespace executor
519518
} // namespace torch
520519

521520
namespace executorch {

0 commit comments

Comments
 (0)