Skip to content

Commit a230538

Browse files
authored
Update CONTRIBUTING.md to reflect "Squash and merge" option
Currently, PR doesn't need to go through internal landing. Reviewers and contributors with "write permission" can just squash and merge and PR themselves. Update the docs to reflect it.
1 parent 8fb1def commit a230538

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,13 @@ for basics.
272272
- If the reviewers have requests or questions, follow up with them.
273273
- The goal of the reviewer is to ensure that the code in the `main` branch of
274274
the repo is consistent, maintainable, and of high quality.
275-
1. Once approved, your reviewer will import the PR into Meta's internal system
276-
and merge it from there.
275+
1. Once approved, your reviewer will merge the PR.
276+
- If you have the "write permission" to repo, and see the "Squash and merge"
277+
button is green and all CI signals are good, you can merge it yourself. The
278+
commit message in the text box when you click "Squash and merge" is the final
279+
commit message in repo, so please make it meaningful.
280+
- The reviewer may import the PR into Meta's internal system to validate it
281+
against internal CI.
277282
- If the PR is approved and not merged within a few business days, please
278283
comment on the PR to ask about its status.
279284
- Note that if the `main` [CI](#continuous-integration) jobs are broken, we

0 commit comments

Comments
 (0)