enforce clang on windows

Author: jathu

.github/workflows/build-presets.yml

@@ -72,24 +72,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        preset: [pybind]
+        preset: [pybind, llm]
     with:
       job-name: build
       ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
       submodules: recursive
       timeout: 90
       script: |
         set -eux
-        conda init powershell
-        powershell -Command "& {
-          \$ErrorActionPreference = 'Stop'
-          Set-PSDebug -Trace 1
+        conda create --yes --quiet -n et python=3.12
+        conda activate et
 
-          conda create --yes --quiet -n et python=3.12
-          conda activate et
-
-          python install_requirements.py
-          cmake --preset ${{ matrix.preset }}
-          \$numCores = [System.Environment]::GetEnvironmentVariable('NUMBER_OF_PROCESSORS') - 1
-          cmake --build cmake-out -j \$numCores
-        }"
+        ./install_requirements.sh
+        cmake -G "Visual Studio 17 2022" -T ClangCL --preset ${{ matrix.preset }}
+        cmake --build cmake-out -j$(( $(nproc) - 1 ))

CMakeLists.txt

@@ -75,6 +75,12 @@ if(NOT PYTHON_EXECUTABLE)
 endif()
 announce_configured_options(PYTHON_EXECUTABLE)
 
+if(WIN32)
+  if(NOT "${CMAKE_GENERATOR_TOOLSET}" STREQUAL "" AND NOT CMAKE_GENERATOR_TOOLSET MATCHES "Clang")
+    message(FATAL_ERROR "Windows builds require Clang compiler. Current CMAKE_GENERATOR_TOOLSET: ${CMAKE_GENERATOR_TOOLSET}")
+  endif()
+endif()
+
 announce_configured_options(CMAKE_CXX_COMPILER_ID)
 announce_configured_options(CMAKE_TOOLCHAIN_FILE)
 announce_configured_options(BUCK2)