Skip to content

Commit aaf8532

Browse files
akriegerfacebook-github-bot
authored andcommitted
Force -O3 for executorch op_div.cpp in "clang 17" also
Summary: Some platforms use clang 19 under the hood but are setting the clang 17 constraint for bad reasons. Differential Revision: D80980948
1 parent f02fab4 commit aaf8532

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,10 @@ OPTIMIZED_ATEN_OPS = (
171171
# is not sufficient to avoid it.
172172
compiler_flags = [] if runtime.is_oss else select({
173173
"DEFAULT": [],
174-
"ovr_config//toolchain/clang/constraints:19": select({
174+
"ovr_config//os:android": select({
175175
"DEFAULT": [],
176-
"ovr_config//os:android": ["-O3"],
176+
"ovr_config//toolchain/clang/constraints:17": ["-O3"],
177+
"ovr_config//toolchain/clang/constraints:19": ["-O3"],
177178
}),
178179
}),
179180
deps = [

0 commit comments

Comments
 (0)